Remove duplicate function in std::ptr with std::ptr::RawPtr #12167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @brson, you've been doing some stuff with these raw pointers lately This looks good to me! |
|
Needs rebase. |
|
It should be ok now. |
|
It would have been nice this commit had merged the more complete (IMO) documentation from the functions it was removing into the documentation for the methods that are meant to replace those functions. (I'm referring to the info for the I'll put up a follow-up PR with that change. |
bors
added a commit
that referenced
this pull request
Feb 21, 2014
…r=alexcrichton ptr::RawPtr, spell out units used for the `offset` argument. spell out units used for the `offset` argument, so that callers do not try to scale to byte units themselves. (this was originally landed in PR #11002 for the stand-alone functions, but that PR did not modify the `RawPtr` methods, since that had no doc at all at the time. Now `RawPtr` has the *only* documentation for `offset`, since the stand-alone functions went away in PR #12167 / PR #12248.)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
fix FP on [`semicolon_if_nothing_returned`] fixes: rust-lang#12123 --- changelog: fix FP on [`semicolon_if_nothing_returned`] which suggesting adding semicolon after attr macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request remove the functions
std::ptr::{offset, mut_offset, is_null, is_not_null}, which are duplicate with the corresponding methods instd::ptr::RawPtr.I don't know if these changes are acceptable / needed, but if it is, maybe we can remove
std::ptr::{null, mut_null}, to use onlystd::ptr::RawPtr::null