Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hidden use of Global #121847

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Remove hidden use of Global #121847

merged 1 commit into from
Mar 2, 2024

Conversation

shamatar
Copy link
Contributor

@shamatar shamatar commented Mar 1, 2024

Fixes #121797

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 1, 2024
@cuviper
Copy link
Member

cuviper commented Mar 1, 2024

I doubt that it matters to have that hidden Global, but in principle the change does make sense.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 1, 2024

📌 Commit fb8ac06 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…
8e11997 
…=cuviper

Remove hidden use of Global

Fixes rust-lang#121797
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2024
@bors
Auto merge of rust-lang#121886 - matthiaskrgr:rollup-z9t269j, r=matth…
9be716e 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#109263 (fix typo in documentation for std::fs::Permissions)
 - rust-lang#120684 (Update E0716.md for clarity)
 - rust-lang#121739 (Display short types for unimplemented trait)
 - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names)
 - rust-lang#121758 (Move thread local implementation to `sys`)
 - rust-lang#121815 (Move `gather_comments`.)
 - rust-lang#121835 (Move `HandleStore` into `server.rs`.)
 - rust-lang#121847 (Remove hidden use of Global)
 - rust-lang#121861 (Use the guaranteed precision of a couple of float functions in docs)
 - rust-lang#121875 ( Account for unmet T: !Copy in E0277 message)

r? `@ghost`
`@rustbot` modify labels: rollup
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 2, 2024
@Dylan-DPC
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…
9c40705 
…=cuviper

Remove hidden use of Global

Fixes rust-lang#121797
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 2, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2024
@bors
Auto merge of rust-lang#121887 - Dylan-DPC:rollup-d00bdxz, r=Dylan-DPC
cbd4772 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#109263 (fix typo in documentation for std::fs::Permissions)
 - rust-lang#117156 (Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits)
 - rust-lang#120684 (Update E0716.md for clarity)
 - rust-lang#121739 (Display short types for unimplemented trait)
 - rust-lang#121815 (Move `gather_comments`.)
 - rust-lang#121835 (Move `HandleStore` into `server.rs`.)
 - rust-lang#121847 (Remove hidden use of Global)
 - rust-lang#121861 (Use the guaranteed precision of a couple of float functions in docs)
 - rust-lang#121875 ( Account for unmet T: !Copy in E0277 message)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2024
@bors
Auto merge of rust-lang#121890 - matthiaskrgr:rollup-mv26uwt, r=matth…
5257aee 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#109263 (fix typo in documentation for std::fs::Permissions)
 - rust-lang#120684 (Update E0716.md for clarity)
 - rust-lang#121715 (match lowering: pre-simplify or-patterns too)
 - rust-lang#121739 (Display short types for unimplemented trait)
 - rust-lang#121815 (Move `gather_comments`.)
 - rust-lang#121835 (Move `HandleStore` into `server.rs`.)
 - rust-lang#121847 (Remove hidden use of Global)
 - rust-lang#121861 (Use the guaranteed precision of a couple of float functions in docs)
 - rust-lang#121875 ( Account for unmet T: !Copy in E0277 message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 78249a6 into rust-lang:master Mar 2, 2024
11 checks passed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…
9996a4a 
…=cuviper

Remove hidden use of Global

Fixes rust-lang#121797
@rustbot rustbot added this to the 1.78.0 milestone Mar 2, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 2, 2024
Closed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 2, 2024
@rust-timer
Unrolled build for rust-lang#121847
3e2cadc 
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r=cuviper

Remove hidden use of Global

Fixes rust-lang#121797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

BTreeMap uses Global allocator in it's PhantomData even when instantiated with custom Allocator
4 participants
@shamatar @rustbot @cuviper @bors