Run some ui-fulldeps tests on stage 1 again #121945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put `#[cfg(bootstrap)]` there to let the bootstrap bumper fix it.
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
Thank you for updating the tests! 🚀 |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121248 (Move some tests) - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`) - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names) - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr) - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121248 (Move some tests) - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`) - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names) - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr) - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2024
Rollup merge of rust-lang#121945 - Nilstrieb:ignore-stage1, r=compiler-errors Run some ui-fulldeps tests on stage 1 again This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put `#[cfg(bootstrap)]` there to let the bootstrap bumper fix it. `@George-lewis` :) finishes rust-lang#119088 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second time I'm doing this... I'm starting to feel like stage1 ui-fulldeps tests were a mistake. Maybe I should have just put
#[cfg(bootstrap)]there to let the bootstrap bumper fix it.@George-lewis :)
finishes #119088 (comment)