snapshot: avoid leaking inference vars #122189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 8, 2024
snapshot: avoid leaking inference vars A first step towards fixing rust-lang#122188. There are still some FIXMEs left, most notably method probing. fixes rust-lang#122098 r? `@oli-obk`
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (970523a): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 652.903s -> 647.701s (-0.80%) |
rustbot
added
perf-regression
oli-obk
reviewed
Mar 8, 2024
| let r = f(&snapshot); | ||
| let no_leaks_data = R::mk_data_snapshot_end(self, no_leaks_data); | ||
| self.rollback_to(snapshot); | ||
| R::avoid_leaks(r, self, no_leaks_data) |
There was a problem hiding this comment.
Maybe it's sufficient to run this with debug assertions? Or is it usually odd cases that have no tests that leak infer vars?
There was a problem hiding this comment.
if we don't fudge TypeError we can get ICE. I would expect that this is the main cause of the regression here. Can add some inline attributes though to check whether it helps with anything
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 8, 2024
snapshot: avoid leaking inference vars A first step towards fixing rust-lang#122188. There are still some FIXMEs left, most notably method probing. fixes rust-lang#122098 r? `@oli-obk`
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (c740aa4): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.792s -> 648.87s (0.01%) |
rustbot
removed
S-waiting-on-perf
|
no tests? |
|
forgot that this actually fixes stuff 😅 adding them |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
probe-no-more-leak
branch
from
9a8da28
to
b0ad8d7
Compare
rustbot
added
A-testsuite
|
most other tests have a different root cause. I have not yet fixed method probing as that's non-trivial. Leaving that for future PRs |
oli-obk
reviewed
Mar 11, 2024
Comment on lines
+176
to
+179
| if let Some(fudge_data) = fudge_data { | ||
| FudgeInference(fudge_data.fudge_inference(infcx, value)) | ||
| } else { | ||
| FudgeInference(value) |
|
@bors r+ I wonder if we can come up with a scheme (that doesn't make all snapshot methods really annoying to use), which also prevents storing types into storage borrowed in the snapshot closure. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
snapshot: avoid leaking inference vars A first step towards fixing rust-lang#122188. There are still some FIXMEs left, most notably method probing. fixes rust-lang#122098 r? `@oli-obk`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
matthiaskrgr
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #122832) made this pull request unmergeable. Please resolve the merge conflicts. |
|
post sync |
This comment was marked as resolved.
This comment was marked as resolved.
|
@lcnr any updates on this? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step towards fixing #122188. There are still some FIXMEs left, most notably method probing.
fixes #122098
r? @oli-obk