-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect __rust_dealloc
to sdallocx
#122329
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @petrochenkov. Use r? to explicitly pick a reviewer |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Redirect `__rust_dealloc` to `sdallocx` This could use a perf run.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (ecb3315): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 645.581s -> 646.145s (0.09%) |
This was previously tried here, although seemingly in a different way. CC @nnethercote |
The PR needs a proper description - what exactly it changes and why it's different from jemalloc overrides below, why it helps, what |
|
If #122362 works out we could probably just do this change with a |
This could use a perf run.