Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #122524

Merged
merged 6 commits into from
Mar 15, 2024
Merged

[beta] backports #122524

merged 6 commits into from
Mar 15, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 15, 2024

r? cuviper

fmease and others added 6 commits March 14, 2024 18:01
@fmease @cuviper
AST validation: Improve handling of inherent impls nested within func…
92512b1 
…tions and anon consts

(cherry picked from commit 7d428db)
@pnkfelix @cuviper
downgrade mutable-ptr-in-final-value from hard-error to future-incomp…
25d3cbb 
…at lint to address issue 121610.

(cherry picked from commit a8549b4)
@pnkfelix @cuviper
regression test from 121610.
6c06ca0 
(cherry picked from commit f86b46a)
@pnkfelix @cuviper
Added deny(const_eval_mutable_ptr_in_final_value) attribute to all …
9cf28f2 
…tests that were expecting the hard error for it.

I attempted to do this in a manner that preserved the line numbers to reduce the
review effort on the resulting diff, but we still have to deal with the
ramifications of how a future-incompat lint behaves compared to a hard-error (in
terms of its impact on the diagnostic output).

(cherry picked from commit 1c3424b)
@pnkfelix @cuviper
Added an "Explanation" header and expanded that section for the newly…
2ade18a 
… added lint.

(cherry picked from commit 6ca46da)
@wesleywiser @cuviper
Add produces as tidy requires
6b0992f 
(cherry picked from commit ae374cf)
@rustbot

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 15, 2024
@cuviper
Copy link
Member Author

cuviper commented Mar 15, 2024

Nudging priority a little since branch promotion will be soon.

@bors r+ p=1 rollup=never

@bors
Copy link
Contributor

bors commented Mar 15, 2024

📌 Commit 6b0992f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024
@bors
Copy link
Contributor

bors commented Mar 15, 2024

⌛ Testing commit 6b0992f with merge 2bcca41...

@bors
Copy link
Contributor

bors commented Mar 15, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 2bcca41 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 15, 2024
@bors bors merged commit 2bcca41 into rust-lang:beta Mar 15, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Mar 15, 2024
@fmease fmease mentioned this pull request Mar 15, 2024
Closed
@cuviper cuviper mentioned this pull request Mar 17, 2024
Open
@cuviper cuviper deleted the beta-next branch March 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cuviper @rustbot @bors @fmease @pnkfelix @wesleywiser