Safe Transmute: Use 'not yet supported', not 'unspecified' in errors #122560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Urgau
reviewed
Mar 15, 2024
| rustc_transmute::Reason::SrcIsUnspecified => { | ||
| format!("`{src}` does not have a well-specified layout") | ||
| rustc_transmute::Reason::SrcIsNotYetSupported => { | ||
| format!("Analyzing the transmutability of `{src}` is not yet supported.") |
There was a problem hiding this comment.
nitpick but there shouldn't be any capital letter at the start of any diagnostic message
Suggested change
| format!("Analyzing the transmutability of `{src}` is not yet supported.") | |
| format!("analyzing the transmutability of `{src}` is not yet supported.") |
| rustc_transmute::Reason::DstIsUnspecified => { | ||
| format!("`{dst}` does not have a well-specified layout") | ||
| rustc_transmute::Reason::DstIsNotYetSupported => { | ||
| format!("Analyzing the transmutability of `{dst}` is not yet supported.") |
There was a problem hiding this comment.
Suggested change
| format!("Analyzing the transmutability of `{dst}` is not yet supported.") | |
| format!("analyzing the transmutability of `{dst}` is not yet supported.") |
rustbot
added
S-waiting-on-author
We can (and will) support analyzing the transmutability of types whose layouts aren't completely specified by its repr. This change ensures that the error messages remain sensible after this support lands.
jswrenn
force-pushed
the
not-yet-supported
branch
from
0f0883a
to
dc35339
Compare
|
I've fixed the uppercased diagnostics changed by this PR. It looks like several other of our diagnostics start with uppercased letters; I'll correct those in a follow-up PR. |
|
Could you just fix it in this PR? No reason to make another PR, since it'll just be blessing some tests. |
|
Done |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 15, 2024
…ler-errors Safe Transmute: Use 'not yet supported', not 'unspecified' in errors We can (and will) support analyzing the transmutability of types whose layouts aren't completely specified by its repr. This change ensures that the error messages remain sensible after this support lands. r? `@compiler-errors`
This was referenced Mar 15, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122254 (Detect calls to .clone() on T: !Clone types on borrowck errors) - rust-lang#122495 (Visually mark 👻hidden👻 items with document-hidden-items) - rust-lang#122543 (Add `#![rustc_never_type_mode = "..."]` crate-level attribute to allow experimenting) - rust-lang#122560 (Safe Transmute: Use 'not yet supported', not 'unspecified' in errors) - rust-lang#122562 (Mention labelled blocks in `break` docs) - rust-lang#122563 (CI: cache PR CI Docker builds) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 15, 2024
Rollup merge of rust-lang#122560 - jswrenn:not-yet-supported, r=compiler-errors Safe Transmute: Use 'not yet supported', not 'unspecified' in errors We can (and will) support analyzing the transmutability of types whose layouts aren't completely specified by its repr. This change ensures that the error messages remain sensible after this support lands. r? ``@compiler-errors``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can (and will) support analyzing the transmutability of types whose layouts aren't completely specified by its repr. This change ensures that the error messages remain sensible after this support lands.
r? @compiler-errors