Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid unnecessary collect() #122633

Merged
merged 1 commit into from
Mar 17, 2024
Merged

avoid unnecessary collect() #122633

merged 1 commit into from
Mar 17, 2024

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2024
@fmease
Copy link
Member

fmease commented Mar 17, 2024

Did you find that via Clippy?

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 17, 2024

📌 Commit b8db431 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
@bors
Auto merge of rust-lang#122637 - matthiaskrgr:rollup-bczj5bp, r=matth…
35dfc67 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#121236 (Don't show suggestion if slice pattern is not top-level)
 - rust-lang#121787 (run change tracker even when config parse fails)
 - rust-lang#122633 (avoid unnecessary collect())

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1213746 into rust-lang:master Mar 17, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
@rust-timer
Unrolled build for rust-lang#122633
291f642 
Rollup merge of rust-lang#122633 - matthiaskrgr:col, r=fmease

avoid unnecessary collect()
@rustbot rustbot added this to the 1.79.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthiaskrgr @rustbot @fmease @bors