Skip to content

Conversation

beetrees
Copy link
Contributor

This PR moves the option_env! tests to there own directory (extoption_env), matching the naming convention used by the tests for env! (which live in the extenv directory).

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2024
@Noratrieb
Copy link
Member

Noratrieb commented Mar 17, 2024

Thanks! Can you move them both to a new env-macro directory instead and drop all the ext prefixes?

@beetrees beetrees changed the title Move option_env! tests to their own directory Move option_env! and env! tests to the env-macro directory Mar 17, 2024
@beetrees
Copy link
Contributor Author

@Nilstrieb Done

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@compiler-errors
Copy link
Member

@bors r=compiler-errors,Nilstrieb rollup

@bors
Copy link
Collaborator

bors commented Mar 18, 2024

📌 Commit 3651401 has been approved by compiler-errors,Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#122639 (Fix typos)
 - rust-lang#122654 (interpret/memory: explain why we use == on bool)
 - rust-lang#122656 (simplify_cfg: rename some passes so that they make more sense)
 - rust-lang#122657 (Move `option_env!` and `env!` tests to the `env-macro` directory)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 069b933 into rust-lang:master Mar 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2024
Rollup merge of rust-lang#122657 - beetrees:option-env-tests, r=compiler-errors,Nilstrieb

Move `option_env!` and `env!` tests to the `env-macro` directory

This PR moves the `option_env!` tests to there own directory (`extoption_env`), matching the naming convention used by the tests for `env!` (which live in the `extenv` directory).
@rustbot rustbot added this to the 1.79.0 milestone Mar 18, 2024
@beetrees beetrees deleted the option-env-tests branch March 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants