Update upload-artifact to v4

[Nilstrieb]

This contains a breaking change around artifact merging no longer being done. This was not relied on, so it's fine.

[rustbot]

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Kobzol]

Hmm, it seems to me that name: "${{ env.DOC_ARTIFACT_NAME }}" might be the same across different jobs, which could cause an error in v4. Anyway, the easiest way to find out is probably to try to merge the change.

@bors r+ rollup=never

[bors]

📌 Commit 24a0d7d has been approved by Kobzol

It is now in the queue for this repository.

[Nilstrieb]

I downloaded the artifact from the last master run and it only contained a single tarball (im the zip, haha).

[Kobzol]

Yeah, which looks like the jobs overwrite the files. Which is weird, given that they should be combined. But from the workflow it looks like all/most jobs should upload it (?).

[Nilstrieb]

I looked through some job logs and the ones I checked didn't actually upload it as there weren't any files.

[Kobzol]

Maybe it is actually uploaded only by a single job. But in that case we should document that better, it's not at all obvious to me why that happens.

[Nilstrieb]

yeah, it's a bit confusing.

[bors]

⌛ Testing commit 24a0d7d with merge fa374a8...

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing fa374a8 to master...

[rust-timer]

Finished benchmarking commit (fa374a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.312s -> 671.665s (0.20%)
Artifact size: 315.10 MiB -> 315.02 MiB (-0.03%)

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Complete job name: skip if S-waiting-on-bors
##[group]Run # Fetch state and labels of PR
# Fetch state and labels of PR
# Or exit successfully if PR does not exist
JSON=$(gh pr view cargo_update --repo $GITHUB_REPOSITORY --json labels,state || exit 0)
STATE=$(echo "$JSON" | jq -r '.state')
WAITING_ON_BORS=$(echo "$JSON" | jq '.labels[] | any(.name == "S-waiting-on-bors"; .)')

# Exit with error if open and S-waiting-on-bors
if [[ "$STATE" == "OPEN" && "$WAITING_ON_BORS" == "true" ]]; then
  gh run cancel 8416913615
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

[Nilstrieb]

@clubby789

[ehuss]

This is unfortunately causing a confusing message on every merged PR due to rust-lang/rust-log-analyzer#81.

[ehuss]

Is the problem with the dependencies workflow that the download-artifact action also needs to be updated to v4?

[Kobzol]

I'm not sure if it's related, the Cargo update workflow started failing a few hours before this PR was merged (https://github.com/rust-lang/rust/actions/workflows/dependencies.yml).