Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the comments for ReturnDest variants doc comments #124052

Merged
merged 1 commit into from Apr 17, 2024
Merged

Make the comments for ReturnDest variants doc comments #124052

merged 1 commit into from Apr 17, 2024

Conversation

beetrees
Copy link
Contributor

This PR converts the documentation for ReturnDest from comments to doc comments.

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2024
@fmease
Copy link
Member

fmease commented Apr 17, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2024

📌 Commit c021367 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@bors
Auto merge of rust-lang#124055 - matthiaskrgr:rollup-waq2e68, r=matth…
b758149 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#122813 (Qualifier tweaking)
 - rust-lang#122883 (refactor clippy in bootstrap)
 - rust-lang#123997 (Delay span bug when `Self` kw resolves to `DefKind::{Mod,Trait}`)
 - rust-lang#124045 (Reinstate nnethercote to the review rotation.)
 - rust-lang#124051 (Fix empty-set symbol in comments)
 - rust-lang#124052 (Make the comments for `ReturnDest` variants doc comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 854303b into rust-lang:master Apr 17, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@rust-timer
Unrolled build for rust-lang#124052
e70aefd 
Rollup merge of rust-lang#124052 - beetrees:return-dest-doc-comment, r=fmease

Make the comments for `ReturnDest` variants doc comments

This PR converts the documentation for `ReturnDest` from comments to doc comments.
@rustbot rustbot added this to the 1.79.0 milestone Apr 17, 2024
@beetrees beetrees deleted the return-dest-doc-comment branch April 17, 2024 06:27
@RalfJung
Copy link
Member

Strange, bors thinks this PR is still in the queue, but it got already merged...
Cc @rust-lang/infra

@RalfJung
Copy link
Member

@bors r-
Does this help?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@beetrees @rustbot @fmease @bors @RalfJung @TaKO8Ki