Skip to content

Conversation

saethlin
Copy link
Member

The goal here is to trim down the number of tests that depend on libc from the sysroot to make #123938 more plausible.

This PR is a few simple cases that I missed in #123943.

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2024
@jieyouxu
Copy link
Member

Thanks for the cleanups 💚
r? jieyouxu
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 17, 2024

📌 Commit 1567d4d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 18, 2024
…=jieyouxu

Remove libc from more tests

The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible.

This PR is a few simple cases that I missed in rust-lang#123943.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#124041 (Fix copy path button)
 - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups)
 - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`)
 - rust-lang#124072 (Remove libc from more tests)
 - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19)
 - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#124109 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2024
@saethlin
Copy link
Member Author

@bors rollup=iffy
@bor r=jieyouxu

@jieyouxu
Copy link
Member

@bors rollup=iffy
@bor r=jieyouxu

wrong bors :3

@saethlin
Copy link
Member Author

Oops, sorry
@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Apr 18, 2024

📌 Commit 8047fad has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2024
@bors
Copy link
Collaborator

bors commented Apr 18, 2024

⌛ Testing commit 8047fad with merge 0e15f5e...

@bors
Copy link
Collaborator

bors commented Apr 18, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 0e15f5e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2024
@bors bors merged commit 0e15f5e into rust-lang:master Apr 18, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 18, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0e15f5e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.567s -> 676.731s (-0.12%)
Artifact size: 315.40 MiB -> 316.11 MiB (0.23%)

@saethlin saethlin deleted the less-sysroot-libc-misc branch May 3, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants