Move thread parking to sys::sync
#124159
Open
Move thread parking to sys::sync
#124159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-SGX
samlh
reviewed
Apr 23, 2024
joboet
force-pushed
the
move_pal_thread_parking
branch
from
f4b0d51
to
6818915
Compare
ChrisDenton
reviewed
Apr 25, 2024
Comment on lines
+1
to
+3
| // Only used on NetBSD. If other platforms start using id-based parking, use | ||
| // separate modules for each platform. | ||
| #![cfg(target_os = "netbsd")] |
There was a problem hiding this comment.
Hmm... I'm not sure I love this being unix/thread_parking.rs with nothing in the path to indicate it's highly platform specific. If more unix targets do use id-based parking, what should they call their modules? How would that be organised?
There was a problem hiding this comment.
Then I'd split them unix/thread_parking/netbsd.rs/unix/thread_parking/*.rs and expose the relevant inferface in unix/thread_parking/mod.rs.
|
☔ The latest upstream changes (presumably #124491) made this pull request unmergeable. Please resolve the merge conflicts. |
joboet
force-pushed
the
move_pal_thread_parking
branch
from
6818915
to
a56fd37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #117276.
I'll leave the platform-specific API abstractions in
sys::pal, as per the initial proposal. I'm not entirely sure whether we'll want to keep it that way, but that remains to be seen.r? @ChrisDenton (if you have time)