-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DefiningOpaqueTypes::Yes
in rustdoc, where the InferCtxt
is guaranteed to have no opaque types it can define
#124168
Conversation
This comment has been minimized.
This comment has been minimized.
ed49307
to
c510140
Compare
This comment has been minimized.
This comment has been minimized.
Ah, I missed the "modulo rustdoc, but that doesn't count". But why doesn't it count? 🤔 |
It does count. In practice, |
One such “other tool” was supposed to be rust-lang/rust-semverver (now archived). However, it never actually got to use |
NB: |
I assumed it was operating on broken code or sth. Should have checked before assuming. I did not realize auto trait finder exists for Rustdoc only |
AFAICT it only does that because the projection cache only uses the |
…ue types it may define
c510140
to
6bff7f4
Compare
DefiningOpaqueTypes::Yes
in rustdoc, where the InferCtxt
is guaranteed to have no opaque types it can define
@bors r+ rollup |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123680 (Deny gen keyword in `edition_2024_compat` lints) - rust-lang#124057 (Fix ICE when ADT tail has type error) - rust-lang#124168 (Use `DefiningOpaqueTypes::Yes` in rustdoc, where the `InferCtxt` is guaranteed to have no opaque types it can define) - rust-lang#124197 (Move duplicated code in functions in `tests/rustdoc-gui/notable-trait.goml`) - rust-lang#124200 (Improve handling of expr->field errors) - rust-lang#124220 (Miri: detect wrong vtables in wide pointers) - rust-lang#124266 (remove an unused type from the reentrant lock tests) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#124168 - oli-obk:define_opaque_types12, r=lcnr Use `DefiningOpaqueTypes::Yes` in rustdoc, where the `InferCtxt` is guaranteed to have no opaque types it can define r? `@lcnr` I manually checked there it's always `tcx.infer_ctxt().build()`
r? @lcnr
I manually checked there it's always
tcx.infer_ctxt().build()