Flip spans for precise capturing syntax not capturing a ty/const param, and for implicit captures of lifetime params #124198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
improve-ty-ct-param-span
branch
from
663ea88
to
fa0428c
Compare
Nadrieril
reviewed
Apr 20, 2024
| | | ||
| LL | trait Foo { | ||
| | ^^^^^^^^^ | ||
| LL | | ||
| | --------- type parameter is implicitly captured by this `impl Trait` |
There was a problem hiding this comment.
Could this be "Self parameter is implicitly captured" instead?
Nadrieril
approved these changes
Apr 20, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#124069 (enable clippy for bootstrap on CI PRs (in `mingw-check` image)) - rust-lang#124089 (Fix watchOS and visionOS for pread64 and pwrite64 calls) - rust-lang#124184 (Suggest using `unsigned_abs` in `abs` documentation) - rust-lang#124198 (Flip spans for precise capturing syntax not capturing a ty/const param, and for implicit captures of lifetime params) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2024
Rollup merge of rust-lang#124198 - compiler-errors:improve-ty-ct-param-span, r=Nadrieril Flip spans for precise capturing syntax not capturing a ty/const param, and for implicit captures of lifetime params Make the primary span point to the opaque, rather than the param which might be very far away (e.g. in an impl header hundreds of lines above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the primary span point to the opaque, rather than the param which might be very far away (e.g. in an impl header hundreds of lines above).