Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a couple tests for fixed ICEs. #124240

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Apr 21, 2024

Fixes #121413
Fixes #121463
Fixes #114463

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2024
// issue rust-lang/rust#123420
// ICE assertion failed: i32 != &'{erased} mut i32
//@ edition:2021
#![feature(async_closure)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go into async-await/async-closures

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, i don't think we even need this test. I added enough tests in #123660.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah neat; I'll boot this one then :)

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 21, 2024

📌 Commit a42adf2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124236 (crashes: add a couple more ICE tests)
 - rust-lang#124240 (add a couple tests for fixed ICEs.)
 - rust-lang#124246 (Add comma at one place in `abs()` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124240 (add a couple tests for fixed ICEs.)
 - rust-lang#124245 (bootstrap: Promote some build_steps comments to docs)
 - rust-lang#124246 (Add comma at one place in `abs()` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3cd56f3 into rust-lang:master Apr 22, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
Rollup merge of rust-lang#124240 - matthiaskrgr:tests_sunday, r=compiler-errors

add a couple tests for fixed ICEs.

Fixes rust-lang#121413
Fixes rust-lang#121463
Fixes rust-lang#114463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
5 participants