Skip to content

Conversation

workingjubilee
Copy link
Member

No new content, just makes some comments readable when viewing the docs with --document-private-items.

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2024

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 22, 2024
@workingjubilee
Copy link
Member Author

why you gotta lie like that rustbot

@onur-ozkan
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 22, 2024

📌 Commit 9470e05 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#124240 (add a couple tests for fixed ICEs.)
 - rust-lang#124245 (bootstrap: Promote some build_steps comments to docs)
 - rust-lang#124246 (Add comma at one place in `abs()` documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e4e660e into rust-lang:master Apr 22, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 22, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
Rollup merge of rust-lang#124245 - workingjubilee:bootstrap-some-doc-comments, r=onur-ozkan

bootstrap: Promote some build_steps comments to docs

No new content, just makes some comments readable when viewing the docs with `--document-private-items`.
@workingjubilee workingjubilee deleted the bootstrap-some-doc-comments branch April 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants