Skip to content

[EXPERIMENT] Crater adding target_family = "linux" #124355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[EXPERIMENT] Crater adding target_family = "linux" #124355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20dae47
Crater-test adding target_family = linux
workingjubilee Apr 24, 2024
bfe956e
Add target_family = apple for good measure
workingjubilee Apr 24, 2024
e6199bd
Fixup missing import
workingjubilee Apr 24, 2024
e1746e0
Split family names in android
workingjubilee Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions compiler/rustc_target/src/spec/base/android.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
use crate::spec::{base, SanitizerSet, TargetOptions, TlsModel};

use crate::spec::cvs;

pub fn opts() -> TargetOptions {
let mut base = base::linux::opts();
base.os = "android".into();
// listing families in different orders seems most chaotic. :^)
base.families = cvs!["unix", "linux"];
base.is_like_android = true;
base.default_dwarf_version = 2;
base.tls_model = TlsModel::Emulated;
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_target/src/spec/base/apple/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ pub fn opts(os: &'static str, arch: Arch) -> TargetOptions {
function_sections: false,
dynamic_linking: true,
pre_link_args: pre_link_args(os, arch, abi),
families: cvs!["unix"],
families: cvs!["apple", "unix"],
is_like_osx: true,
// LLVM notes that macOS 10.11+ and iOS 9+ default
// to v4, so we do the same.
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_target/src/spec/base/linux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pub fn opts() -> TargetOptions {
TargetOptions {
os: "linux".into(),
dynamic_linking: true,
families: cvs!["unix"],
families: cvs!["linux", "unix"],
has_rpath: true,
position_independent_executables: true,
relro_level: RelroLevel::Full,
Expand Down