Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check-cfg CLI errors with more structured diagnostics #124679

Merged
merged 2 commits into from
May 6, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 3, 2024

This PR improve check-cfg CLI errors with more structured diagnostics.

In particular it now shows the statement where the error occurred, what kind lit it is, as well as pointing users to the doc for more details.

@rustbot label +F-check-cfg

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 3, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the F-check-cfg --check-cfg label May 3, 2024
@bors
Copy link
Contributor

bors commented May 4, 2024

☔ The latest upstream changes (presumably #124345) made this pull request unmergeable. Please resolve the merge conflicts.

@Urgau Urgau force-pushed the check-cfg-structured-cli-errors branch from 81830c5 to f39d5b1 Compare May 4, 2024 14:54
@nnethercote
Copy link
Contributor

r=me after rebasing.

@Urgau Urgau force-pushed the check-cfg-structured-cli-errors branch from f39d5b1 to 228496e Compare May 6, 2024 06:13
@Urgau
Copy link
Member Author

Urgau commented May 6, 2024

@nnethercote I believe I did two days ago. At least rebasing locally doesn't give any conflict.

But anyway, rebased and push.

@nnethercote
Copy link
Contributor

Ah, yep.

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2024

📌 Commit 228496e has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2024
@bors
Copy link
Contributor

bors commented May 6, 2024

⌛ Testing commit 228496e with merge 69f53f5...

@bors
Copy link
Contributor

bors commented May 6, 2024

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 69f53f5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2024
@bors bors merged commit 69f53f5 into rust-lang:master May 6, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 6, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (69f53f5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.088s -> 674.594s (0.08%)
Artifact size: 315.91 MiB -> 315.87 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-check-cfg --check-cfg merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants