Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 specific hotpatch flag to rustc #124966

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nebulark
Copy link
Contributor

@nebulark nebulark commented May 10, 2024

Add unstable ms-hotpatch option to the compiler working similar as /hotpatch in msvc
See: https://learn.microsoft.com/en-us/cpp/build/reference/hotpatch-create-hotpatchable-image?view=msvc-170&viewFallbackFrom=vs-2019

Invoking cargo with 'RUSTFLAGS="-Zhotpatch -C link-arg=-functionpadmin" cargo build --release' creates the desired outcome.

Mostly based on llvm/llvm-project@5af2433

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2024
@nebulark
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@rust-log-analyzer

This comment has been minimized.

@nebulark nebulark changed the title [Experimenting] Add hotpatch flag to rustc Add hotpatch flag to rustc May 10, 2024
@nebulark nebulark changed the title Add hotpatch flag to rustc Add x86 specific hotpatch flag to rustc May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants