Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate run-make/c-link-to-rust-va-list-fn to rmake #125026

Merged
merged 4 commits into from May 14, 2024
Merged

Migrate run-make/c-link-to-rust-va-list-fn to rmake #125026

merged 4 commits into from May 14, 2024

Conversation

Oneirical
Copy link
Contributor

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

@Oneirical Oneirical changed the title Migrate run-make/c-link-to-rust-va-list-fn to rmake Migrate run-make/c-link-to-rust-va-list-fn to rmake May 11, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request May 13, 2024
Open
jieyouxu
jieyouxu approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Contributor

@bors r+ rollup=iffy (this might bounce due to cc differences)

@bors
Copy link
Contributor

bors commented May 13, 2024

📌 Commit 10c358f has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2024
@bors
Copy link
Contributor

bors commented May 13, 2024

⌛ Testing commit 10c358f with merge b3069d5...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 13, 2024
@bors
Auto merge of rust-lang#125026 - Oneirical:clink-tests, r=jieyouxu
b3069d5 
Migrate `run-make/c-link-to-rust-va-list-fn` to `rmake`

Part of rust-lang#121876.

r? `@jieyouxu`
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 13, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 13, 2024
@jieyouxu
Copy link
Contributor

Needs x fmt

@jieyouxu
Copy link
Contributor

Thanks, r=me after CI is green

@bors delegate+

@bors
Copy link
Contributor

bors commented May 14, 2024

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Oneirical
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented May 14, 2024

📌 Commit 812f897 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 14, 2024
@bors
Copy link
Contributor

bors commented May 14, 2024

⌛ Testing commit 812f897 with merge 58426f4...

@bors
Copy link
Contributor

bors commented May 14, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 58426f4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 14, 2024
@bors bors merged commit 58426f4 into rust-lang:master May 14, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 14, 2024
@bors bors mentioned this pull request May 14, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (58426f4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.553s -> 677.153s (-0.06%)
Artifact size: 316.02 MiB -> 315.90 MiB (-0.04%)

@Oneirical Oneirical deleted the clink-tests branch May 15, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Oneirical @rustbot @rust-log-analyzer @jieyouxu @bors @rust-timer