Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_lint cleanups #125057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rustc_lint cleanups #125057

wants to merge 3 commits into from

Conversation

nnethercote
Copy link
Contributor

Minor improvements I found while looking through this code.

r? @cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 13, 2024
@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@bors
Copy link
Contributor

bors commented May 21, 2024

☔ The latest upstream changes (presumably #124097) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote
Copy link
Contributor Author

I rebased.

@bors
Copy link
Contributor

bors commented May 24, 2024

☔ The latest upstream changes (presumably #125434) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote
Fix up comments.
974a7f5 
Wrap overly long ones, etc.
@nnethercote
Reduce some pub exposure.
943d3b1
@nnethercote
Tweak CheckLintNameResult::Tool.
f279d3e 
It has a clumsy type, with repeated `&'a [LintId]`, and sometimes
requires an empty string that isn't used in the `Err`+`None` case.

This commit splits it into two variants.
@nnethercote
Copy link
Contributor Author

I rebased and added the check_gated_lint to the other case. The first commit also disappeared because I ended up doing that extern crate tracing; removal in #125434. Should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nnethercote @bors @cjgillot @rustbot