[CI] Upload average CPU utilization of CI jobs to DataDog #125771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
Kobzol
changed the title
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2024
[CI] Upload CI metrics to DataDog This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level. r? `@jdno`
|
☀️ Try build successful - checks-actions |
Kobzol
force-pushed
the
ci-datadog-metrics
branch
from
608d825
to
ddae1fa
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2024
[CI] Upload CI metrics to DataDog This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level. r? `@jdno`
|
☀️ Try build successful - checks-actions |
Kobzol
force-pushed
the
ci-datadog-metrics
branch
from
ddae1fa
to
8934848
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2024
[CI] Upload CI metrics to DataDog This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level. r? `@jdno`
Kobzol
force-pushed
the
ci-datadog-metrics
branch
2 times, most recently
from
2343ecd
to
870653f
Compare
Kobzol
changed the title
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2024
[CI] Upload average CPU utilization of CI jobs to DataDog This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs. r? `@jdno`
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
ci-datadog-metrics
branch
2 times, most recently
from
a7fbb47
to
f7acf06
Compare
Kobzol
force-pushed
the
ci-datadog-metrics
branch
from
f7acf06
to
95db961
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 3, 2024
[CI] Upload average CPU utilization of CI jobs to DataDog This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs. r? `@jdno`
|
☀️ Try build successful - checks-actions |
|
@rustbot ready |
Urgau
reviewed
Jul 3, 2024
| DATADOG_API_KEY: ${{ secrets.DATADOG_API_KEY }} | ||
| DD_GITHUB_JOB_NAME: ${{ matrix.name }} | ||
| run: | | ||
| npm install -g @datadog/datadog-ci |
There was a problem hiding this comment.
should this npm install be pinned in order to prevent new version breakage?
maybe something like this npm install -g @datadog/datadog-ci@2.38.x or npm install -g @datadog/datadog-ci@^2.x.x
There was a problem hiding this comment.
Good point, I was also thinking about that. If we do pin, the version should stay the same (even though transitive dependencies can still be updated without a lockfile), but the command might eventually no longer be supported by DataDog (meaning its internal API can change), so it might also break our CI in the future. If we don't pin, then it can break if the external CLI changes.
I'm fine with pinning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs.
r? @jdno