ci: Update centos:7 to use vault repos #126352

cuviper · 2024-06-12T19:58:28Z

CentOS 7 is going EOL on June 30, after which its package repos will no
longer exist on the regular mirrors. We'll still be able to access
packages from the vault server though, and can start doing so now. This
affects dist-i686-linux and dist-x86_64-linux.

I also removed epel-release because we were only using that for its
cmake3, but we've been building our own version for a while.

try-job: dist-i686-linux
try-job: dist-x86_64-linux

CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while.

rustbot · 2024-06-12T19:58:36Z

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

cuviper · 2024-06-12T19:59:08Z

We probably want this on 1.80-beta too, in case the image needs a rebuild after that EOL.

@rustbot label +beta-nominated

Kobzol · 2024-06-13T06:14:52Z

What is the longevity of the vault? It seems like they keep everything old there? I'm just wondering if it's possible that they suddenly remove some packages and it breaks our CI.

Also, I wonder if it's time to use something else than CentOS 7 for the "old glibc" CI scenario, since it goes EOL? 🤔

@bors try

ci: Update centos:7 to use vault repos CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while. try-job: dist-i686-linux try-job: dist-x86_64-linux

bors · 2024-06-13T06:16:03Z

⌛ Trying commit 6d2493b with merge b042815...

bors · 2024-06-13T10:25:01Z

☀️ Try build successful - checks-actions
Build commit: b042815 (b0428159e39e4acb27b45c376560bba4b615c82d)

Kobzol · 2024-06-13T13:24:56Z

Try build went fine, and this is just a package repository change, so nothing major.

@bors r+

bors · 2024-06-13T13:24:59Z

📌 Commit 6d2493b has been approved by Kobzol

It is now in the queue for this repository.

cuviper · 2024-06-13T16:00:15Z

What is the longevity of the vault? It seems like they keep everything old there? I'm just wondering if it's possible that they suddenly remove some packages and it breaks our CI.

I can't tell the future, but I think it's a good sign that right now it still goes back to the very first CentOS 2. There are also third-party mirrors of this content, like https://archive.kernel.org/centos-vault/.

Also, I wonder if it's time to use something else than CentOS 7 for the "old glibc" CI scenario, since it goes EOL? 🤔

It would be nice if we could just use crosstool-ng for this too, but last I tried it was messy when the host is nearly the same as the "cross" target, trying to keep those separate. Maybe I was doing something wrong though, or maybe it has improved...

On the user side, I expect many folks will keep clinging to CentOS 7 with a death grip, despite being EOL...

Kobzol · 2024-06-13T16:06:16Z

On the user side, I expect many folks will keep clinging to CentOS 7 with a death grip, despite being EOL...

Probably true, although even our HPC cluster has now upgraded to Rocky Linux 8 from CentOS 7, so that's not a good sign 😁

Let's keep what we have for now.

ci: Update centos:7 to use vault repos CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while. try-job: dist-i686-linux try-job: dist-x86_64-linux

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#125293 (Place tail expression behind terminating scope) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126399 (extend the check for LLVM build) r? `@ghost` `@rustbot` modify labels: rollup

ci: Update centos:7 to use vault repos CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while. try-job: dist-i686-linux try-job: dist-x86_64-linux

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126128 (Consistently use subtyping in method resolution) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) r? `@ghost` `@rustbot` modify labels: rollup

ci: Update centos:7 to use vault repos CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while. try-job: dist-i686-linux try-job: dist-x86_64-linux

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) - rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0) r? `@ghost` `@rustbot` modify labels: rollup

ci: Update centos:7 to use vault repos CentOS 7 is going EOL on June 30, after which its package repos will no longer exist on the regular mirrors. We'll still be able to access packages from the vault server though, and can start doing so now. This affects `dist-i686-linux` and `dist-x86_64-linux`. I also removed `epel-release` because we were only using that for its `cmake3`, but we've been building our own version for a while. try-job: dist-i686-linux try-job: dist-x86_64-linux

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#125829 (rustc_span: Add conveniences for working with span formats) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126354 (Use `Variance` glob imported variants everywhere) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid) - rust-lang#126472 (build `libcxx-version` only when it doesn't exist) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-06-15T08:55:04Z

@bors r- rollup=iffy
may have failed here? 🤔
#126503 (comment)

Kobzol · 2024-06-15T12:20:23Z

@matthiaskrgr I think #126192 is the most likely culprit, given the error mesasge:

2024-06-15T04:06:31.1976815Z Following targets supported from the stage0 compiler, please remove them from STAGE0_MISSING_TARGETS list.
2024-06-15T04:06:31.1977782Z   i686-unknown-redox

matthiaskrgr · 2024-06-15T13:08:09Z

mmh, well we can mark both of them iffy and give it another go I guess
@bors r=Kobzol

bors · 2024-06-15T13:08:11Z

📌 Commit 6d2493b has been approved by Kobzol

It is now in the queue for this repository.

bors · 2024-06-15T22:54:10Z

⌛ Testing commit 6d2493b with merge d5b34a2...

bors · 2024-06-16T01:06:38Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing d5b34a2 to master...

rust-timer · 2024-06-16T02:20:58Z

Finished benchmarking commit (d5b34a2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.1%	[-5.1%, -5.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.1%	[-5.1%, -5.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.839s -> 671.095s (0.19%)
Artifact size: 320.39 MiB -> 320.43 MiB (0.01%)

cuviper · 2024-06-21T16:51:00Z

This EOL reminder mentions that the mirrorlist server will be decommissioned, so we definitely need this on beta.

@rustbot label +beta-accepted

[beta] backports - Only compute `specializes` query if (min)specialization is enabled in the crate of the specializing impl rust-lang#126139 - Add pub struct with allow(dead_code) into worklist rust-lang#126315 - ci: Update centos:7 to use vault repos rust-lang#126352 r? cuviper

rustbot assigned Kobzol Jun 12, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 12, 2024

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 12, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 6 pull requests #126461

Closed

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 5 pull requests #126465

Closed

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 8 pull requests #126480

Closed

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 8 pull requests #126486

Closed

matthiaskrgr mentioned this pull request Jun 15, 2024

Rollup of 7 pull requests #126503

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2024

bors merged commit d5b34a2 into rust-lang:master Jun 16, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jun 16, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 21, 2024

cuviper mentioned this pull request Jun 21, 2024

[beta] backports #126772

Merged

cuviper modified the milestones: 1.81.0, 1.80.0 Jun 21, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Update centos:7 to use vault repos #126352

ci: Update centos:7 to use vault repos #126352

cuviper commented Jun 12, 2024 •

edited by Kobzol

Loading

rustbot commented Jun 12, 2024

cuviper commented Jun 12, 2024

Kobzol commented Jun 13, 2024

bors commented Jun 13, 2024

bors commented Jun 13, 2024

Kobzol commented Jun 13, 2024

bors commented Jun 13, 2024

cuviper commented Jun 13, 2024

Kobzol commented Jun 13, 2024 •

edited

Loading

matthiaskrgr commented Jun 15, 2024

Kobzol commented Jun 15, 2024

matthiaskrgr commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 16, 2024

rust-timer commented Jun 16, 2024

cuviper commented Jun 21, 2024

ci: Update centos:7 to use vault repos #126352

ci: Update centos:7 to use vault repos #126352

Conversation

cuviper commented Jun 12, 2024 • edited by Kobzol Loading

rustbot commented Jun 12, 2024

cuviper commented Jun 12, 2024

Kobzol commented Jun 13, 2024

bors commented Jun 13, 2024

bors commented Jun 13, 2024

Kobzol commented Jun 13, 2024

bors commented Jun 13, 2024

cuviper commented Jun 13, 2024

Kobzol commented Jun 13, 2024 • edited Loading

matthiaskrgr commented Jun 15, 2024

Kobzol commented Jun 15, 2024

matthiaskrgr commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 15, 2024

bors commented Jun 16, 2024

rust-timer commented Jun 16, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

cuviper commented Jun 21, 2024

cuviper commented Jun 12, 2024 •

edited by Kobzol

Loading

Kobzol commented Jun 13, 2024 •

edited

Loading