Skip to content

Allow "C-unwind" fn to have C variadics #126843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2024
Merged

Allow "C-unwind" fn to have C variadics #126843

merged 2 commits into from
Jun 23, 2024

Conversation

workingjubilee
Copy link
Member

Fixes #126836

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2024
@workingjubilee workingjubilee added F-c_variadic `#![feature(c_variadic)]` F-c_unwind `#![feature(c_unwind)]` labels Jun 22, 2024
@nnethercote
Copy link
Contributor

I think you need to update the ast_passes_bad_c_variadic message to mention "C-variadic"?

only foreign or unsafe extern "C" functions may be C-variadic

r=me with that.

@workingjubilee
Copy link
Member Author

ah, good catch!

@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2024

📌 Commit 43a6b01 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2024
@bors
Auto merge of rust-lang#126855 - matthiaskrgr:rollup-ap5m2l6, r=matth…
05468cf 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#126720 (Ignore `branch-protection-check-IBT` run-make test)
 - rust-lang#126779 (Try to clarify the confusingly-named `RustDev` and `RustcDev` steps)
 - rust-lang#126782 (Support absolute source paths in bootstrap)
 - rust-lang#126783 (Fix issue number for the `tcplistener_into_incoming` feature)
 - rust-lang#126843 (Allow "C-unwind" fn to have C variadics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9459fc2 into rust-lang:master Jun 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2024
@rust-timer
Unrolled build for rust-lang#126843
a6134d9 
Rollup merge of rust-lang#126843 - workingjubilee:allow-variadics-in-c-unwind, r=nnethercote

Allow "C-unwind" fn to have C variadics

Fixes rust-lang#126836
@rustbot rustbot added this to the 1.81.0 milestone Jun 23, 2024
@workingjubilee workingjubilee deleted the allow-variadics-in-c-unwind branch June 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
F-c_unwind `#![feature(c_unwind)]` F-c_variadic `#![feature(c_variadic)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.

C-variadic functions may not be extern "C-unwind"
4 participants
@workingjubilee @rustbot @nnethercote @bors