Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

Cherry-picks "rustdoc: clean up and fix ord violations in item sorting #128146" to beta.

r? @Mark-Simulacrum

Based on e3fdafc with a few
minor changes:

- The name sorting function is changed to follow the [version sort]
  from the style guide
- the `cmp` function is redesigned to more obviously make a
  partial order, by always return `cmp()` of the same variable as
  the `!=` above

[version sort]: https://doc.rust-lang.org/nightly/style-guide/index.html#sorting

Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 25, 2024
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Jul 25, 2024

📌 Commit c547831 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2024
@bors
Copy link
Collaborator

bors commented Jul 25, 2024

⌛ Testing commit c547831 with merge 08328a3...

@bors
Copy link
Collaborator

bors commented Jul 25, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 08328a3 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2024
@bors bors merged commit 08328a3 into rust-lang:beta Jul 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 25, 2024
@Mark-Simulacrum Mark-Simulacrum deleted the beta-next branch July 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants