Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on 'make dist' #13063

Merged
merged 23 commits into from
Mar 25, 2014
Merged

Work on 'make dist' #13063

merged 23 commits into from
Mar 25, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Mar 21, 2014

Several things here:

  • Cleanup
  • Fix build targets for building .pkg so that it works and works for all hosts
  • Adds support for nightly artifacts
  • Put docs in a location suitable for upload to s3 during 'make dist'
  • Add coverage of unix binary installers to 'distcheck'
  • Fix 'distcheck'
  • Change 'dist' to build source tarballs, binary tarballs and OS X packages

@brson
Copy link
Contributor Author

brson commented Mar 22, 2014

This now also replaces the existing make install and make uninstall with calls to install.sh, making all the installers except for the windows exe and mac pkg go through the same code path. This gives me much more confidence that make uninstall won't eat my computer, but comes with a minor regression that --mandir no longer works. I'm still considering whether to support it.

@brson
Copy link
Contributor Author

brson commented Mar 22, 2014

cc #9876, #9877

@brson
Copy link
Contributor Author

brson commented Mar 24, 2014

I'm not quite happy with this yet.

brson added 23 commits March 24, 2014 14:29
This doesn't work quite right yet (we need to build packages for all hosts)
and I'm not ready to turn on new dist artifacts yet, but I want to start doing
dry runs for 0.10, so I'm turning this off for now.
Just to be more logical, put big headers between different installers
For integrating doc upload into the dist-snap process
Also, add more distcheck tests
I think there are likely to be scenarios where this script is run
to move files to the correct place during cross-compiles.
The way it was formulated you could only 'prepare' one directory per build.
bors added a commit that referenced this pull request Mar 25, 2014
Several things here:

* Cleanup
* Fix build targets for building .pkg so that it works and works for all hosts
* Adds support for nightly artifacts
* Put docs in a location suitable for upload to s3 during 'make dist'
* Add coverage of unix binary installers to 'distcheck'
* Fix 'distcheck'
* Change 'dist' to build source tarballs, binary tarballs and OS X packages
@bors bors closed this Mar 25, 2014
@bors bors merged commit 39b48fb into rust-lang:master Mar 25, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 23, 2022
Implement lsp extension for cancelling running flychecks

Fixes rust-lang/rust-analyzer#4828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants