Skip to content

Week off of reviews to focus on docs #131232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Week off of reviews to focus on docs #131232

merged 1 commit into from
Oct 4, 2024

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Oct 4, 2024 •
edited
Loading

Dedicating a week to work on rustc-dev-guide.
Should be back on Oct. 11/12.

@jieyouxu
Week off of reviews to focus on docs
0369ee4 
Dedicating a week to work on rustc-dev-guide.
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2024
@bjorn3
Copy link
Member

bjorn3 commented Oct 4, 2024

There PR's are fine to self-approve.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 4, 2024

📌 Commit 0369ee4 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 4, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2024
@bors
Auto merge of rust-lang#131237 - GuillaumeGomez:rollup-il2i7z7, r=Gui…
c39f318 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131034 (Implement RFC3695 Allow boolean literals as cfg predicates)
 - rust-lang#131202 (Use wide pointers consistenly across the compiler)
 - rust-lang#131230 (Enable `--no-sandbox` option by default for rustdoc GUI tests)
 - rust-lang#131232 (Week off of reviews to focus on docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d69af7 into rust-lang:master Oct 4, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2024
@rust-timer
Unrolled build for rust-lang#131232
8b6443a 
Rollup merge of rust-lang#131232 - jieyouxu:docs-week, r=bjorn3

Week off of reviews to focus on docs

Dedicating a week to work on rustc-dev-guide.
Should be back on Oct. 11/12.
@rustbot rustbot added this to the 1.83.0 milestone Oct 4, 2024
@jieyouxu jieyouxu deleted the docs-week branch October 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jieyouxu @rustbot @bjorn3 @bors @Mark-Simulacrum