Skip to content

[beta] Backport rust-lang/rust-analyzer#18711 #134464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

[beta] Backport rust-lang/rust-analyzer#18711 #134464

merged 1 commit into from
Dec 27, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 18, 2024 •
edited by Noratrieb
Loading

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2024
@Veykril Veykril changed the title Backport rust-lang/rust analyzer#18711 Backport rust-lang/rust-analyzer#18711 Dec 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 18, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@Veykril
Copy link
Member Author

Veykril commented Dec 18, 2024

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Dec 18, 2024
@Veykril Veykril force-pushed the backport/rust-analyzer/18711 branch from 398ffc0 to 840f658 Compare December 18, 2024 13:18
@Mark-Simulacrum Mark-Simulacrum changed the title Backport rust-lang/rust-analyzer#18711 [beta] Backport rust-lang/rust-analyzer#18711 Dec 26, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Dec 26, 2024

📌 Commit 840f658 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2024
@bors
Copy link
Collaborator

bors commented Dec 27, 2024

⌛ Testing commit 840f658 with merge 0857a8e...

@bors
Copy link
Collaborator

bors commented Dec 27, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 0857a8e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 27, 2024
@bors bors merged commit 0857a8e into rust-lang:beta Dec 27, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Dec 27, 2024
@Veykril Veykril deleted the backport/rust-analyzer/18711 branch December 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Veykril @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @jieyouxu