Skip to content

Conversation

btj
Copy link
Contributor

@btj btj commented Jan 28, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 28, 2025
@cuviper
Copy link
Member

cuviper commented Jan 28, 2025

Is there some discussion or other context indicating that this was incorrect?

@btj
Copy link
Contributor Author

btj commented Jan 28, 2025

No. I was reading the source file and noticed this comment, which seems pretty obviously wrong. The root is being deallocated, so there's no way that references to it remain valid. (Context: I'm considering having a go at AWS Rust Verification Contest Challenge 4 with my VeriFast tool.)

@cuviper
Copy link
Member

cuviper commented Jan 30, 2025

LGTM, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 30, 2025

📌 Commit 810e4c1 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2025
@bors bors merged commit 3a2f26f into rust-lang:master Jan 30, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants