Skip to content

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 24, 2025

r? @ghost

infiniteregrets and others added 30 commits February 17, 2025 10:36
fix formatting
Ignore assists with many results if grouping not supported
…-url

doc: use fully qualified url for source path
it is stable since 1.52
fix dead links
…-line-anchor

doc: missed the L for the line number
internal: Use ubuntu-latest workers for releases
…-macro

Use correct working directory for non-workspace proc-macro execution
fix typos in snippets
minor: Improve unset `OUT_DIR` error message
fix dead link
lnicola and others added 15 commits February 22, 2025 09:07
fix: Binding wrong associated type when lowering bounds like `T: Trait<Assoc = U>`
When running `cargo codegen` the cwd="rust-analyzer" however when running `cargo test` the cwd="rust-analyzer/xtask" which makes the codegen panic
When running `cargo codegen` the `crates/parser/test_data/generated/runner.rs` file is only updated when some file in `crates/parser/test_data/inline` changes. However this is not sufficient in all cases
Parser inline test codegen panics and/or does not run
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@lnicola
Copy link
Member Author

lnicola commented Feb 24, 2025

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Feb 24, 2025

📌 Commit 6d9b9c1 has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2025
@bors
Copy link
Collaborator

bors commented Feb 24, 2025

⌛ Testing commit 6d9b9c1 with merge 617aad8...

@bors
Copy link
Collaborator

bors commented Feb 24, 2025

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 617aad8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2025
@bors bors merged commit 617aad8 into rust-lang:master Feb 24, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 24, 2025
@lnicola lnicola deleted the sync-from-ra branch February 24, 2025 17:10
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (617aad8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 359.63 MiB -> 359.63 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.