Keep space if arg does not follow punctuation when lint unused parens

[mu001999]

Fixes #138234

If the arg follows punctuation, still pass left_pos with None and no space will be added, else then pass left_pos with Some(arg.span.lo()), so that we can add the space as expected.

And emit_unused_delims can make sure no more space will be added if the expr follows space.

---

Edited:

Directly use the value_span to check whether the expr removed parens will follow identifier or be followed by identifier.

[mu001999]

r? compiler

[compiler-errors]

Computing source information can be very expensive, since this operates on the "good path".

@bors try @rust-timer queue

[bors]

⌛ Trying commit 42ce300 with merge 3bb53a8...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3bb53a8 (3bb53a8f01333496b0195c53a7ae030a1aae2ec4)

[rust-timer]

Finished benchmarking commit (3bb53a8): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	4.9%	[0.2%, 117.0%]	186
Regressions ❌ (secondary)	11.0%	[0.2%, 75.0%]	50
Improvements ✅ (primary)	-0.6%	[-1.3%, -0.3%]	3
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	4.8%	[-1.3%, 117.0%]	189

Max RSS (memory usage)

Results (primary 1.4%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	1.3%	[0.7%, 1.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

Cycles

Results (primary 19.9%, secondary 65.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	20.3%	[0.8%, 187.7%]	57
Regressions ❌ (secondary)	65.0%	[1.7%, 154.5%]	15
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	19.9%	[-0.9%, 187.7%]	58

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.776s -> 779.66s (0.50%)
Artifact size: 365.58 MiB -> 365.48 MiB (-0.03%)

[mu001999]

oops...

[compiler-errors]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Dylan-DPC]

@mu001999 any updates on this? thakns

[mu001999]

@mu001999 any updates on this? thakns

Not yet

[mu001999]

@rustbot ready

[compiler-errors]

@bors try @rust-timer queue

r? compiler

[rust-bors]

☀️ Try build successful (CI)
Build commit: 8b4c215 (8b4c2155699c26493cf0dc8d14f134682939c5d7, parent: 52618eb338609df44978b0ca4451ab7941fd1c7a)

[rust-timer]

Finished benchmarking commit (8b4c215): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[2.0%, 4.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.182s -> 473.508s (-0.14%)
Artifact size: 390.15 MiB -> 390.18 MiB (0.01%)

[jackh726]

Can you add //@ run-rustfix to the test? Seems like a good case.

[jackh726]

r=me after adding run-rustfix

@bors delegate+

[bors]

✌️ @mu001999, you can now approve this pull request!

If @jackh726 told you to "r=me" after making some further change, please make that change, then do @bors r=@jackh726

[mu001999]

@bors r=@jackh726

[bors]

📌 Commit 9991ec2 has been approved by jackh726

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9991ec2 with merge a9d0a6f...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing a9d0a6f to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing eec6bd9 (parent) -> a9d0a6f (this PR)

Test differences

Show 28 test diffs

Stage 1

• [ui] tests/ui/lint/unused_parens_follow_ident.rs: [missing] -> pass (J0)

Stage 2

• [ui] tests/ui/lint/unused_parens_follow_ident.rs: [missing] -> pass (J1)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
• J1: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-19, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a9d0a6f15533a364816c4d81e2192009ef601d33 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-x86_64-apple: 6905.8s -> 9059.0s (31.2%)
2. aarch64-apple: 4414.0s -> 5608.5s (27.1%)
3. dist-apple-various: 4218.4s -> 3411.8s (-19.1%)
4. dist-aarch64-msvc: 6105.7s -> 5524.6s (-9.5%)
5. dist-aarch64-apple: 6802.3s -> 7427.7s (9.2%)
6. aarch64-msvc-1: 7425.8s -> 6846.1s (-7.8%)
7. dist-armv7-linux: 4942.0s -> 5316.3s (7.6%)
8. dist-ohos-x86_64: 4276.4s -> 4543.9s (6.3%)
9. aarch64-gnu-llvm-19-2: 2193.9s -> 2324.6s (6.0%)
10. aarch64-msvc-2: 5467.4s -> 5151.8s (-5.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (a9d0a6f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.7%, -2.5%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.048s -> 473.815s (0.16%)
Artifact size: 390.57 MiB -> 390.60 MiB (0.01%)