Skip to content

Update to new attribute parsing infra implemented in PR #135726 #138386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update to new attribute parsing infra implemented in PR #135726 #138386

wants to merge 1 commit into from
+43 −7

Conversation

vayunbiyani
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2025
@nnethercote
Copy link
Contributor

@jdonszelmann: can you run an eye over this? You'll have a much better idea than me about it.

@jdonszelmann
Copy link
Contributor

Will do, give me a few hours :)

@vayunbiyani
Copy link
Contributor Author

Actually this isn't ready yet. In rolling back the commits locally to get to a working state, It came to a state that does not implement the new practice as intended

@bors
Copy link
Collaborator

bors commented Mar 21, 2025

☔ The latest upstream changes (presumably #138791) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote
Copy link
Contributor

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 28, 2025
@Dylan-DPC
Copy link
Member

@vayunbiyani any updates on this? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nnethercote nnethercote

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vayunbiyani @rustbot @nnethercote @jdonszelmann @bors @Dylan-DPC