Skip to content

Added get_unchecked and get_unchecked_mut to OnceLock and LazyLock #138914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added get_unchecked and get_unchecked_mut to OnceLock and LazyLock #138914

wants to merge 2 commits into from

Conversation

HomelikeBrick42
Copy link
Contributor

@HomelikeBrick42 HomelikeBrick42 commented Mar 24, 2025 •
edited
Loading

This adds methods for avoiding the atomic checks when accessing the value in a OnceLock or LazyLock

@rustbot
Copy link
Collaborator

rustbot commented Mar 24, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 24, 2025
@HomelikeBrick42
Copy link
Contributor Author

i dont know if the issue number can just point to a pull request? do i have to make a separate issue?

@jhpratt
Copy link
Member

jhpratt commented Mar 25, 2025

This should go through an ACP first to gauge team interest.

@jhpratt jhpratt added needs-acp This change is blocked on the author creating an ACP. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2025
@Dylan-DPC Dylan-DPC added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 4, 2025
@jhpratt
Copy link
Member

jhpratt commented Sep 12, 2025

@HomelikeBrick42 Do you intend to open an ACP for this?

@HomelikeBrick42
Copy link
Contributor Author

i was going to but then i forgot about it, ill make one now

@HomelikeBrick42
Copy link
Contributor Author

i have made an ACP rust-lang/libs-team#654

@jhpratt jhpratt added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. needs-acp This change is blocked on the author creating an ACP. labels Sep 14, 2025
@kennytm kennytm mentioned this pull request Sep 15, 2025
Open
@jhpratt jhpratt added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Sep 17, 2025
@jhpratt
Copy link
Member

jhpratt commented Sep 17, 2025

With the ACP now accepted, we just need a tracking issue and the issue number updated in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhpratt jhpratt

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HomelikeBrick42 @rustbot @jhpratt @Dylan-DPC