Skip to content

Conversation

apiraino
Copy link
Contributor

As discussed on Zulip.

To be clear, this is not a value judgement, it's just a way to improve our fairness when assigning reviews, trying to find a balance between leaving time to Rust contributors review on their terms and availability and avoid having PRs waiting for too long.

Important

This is not a final decision! Rust contributors are free to re-add themselves back to the active review rotation (if they feel like it) once they have more availability.

cc: @cjgillot

@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@apiraino apiraino force-pushed the remove-cjgillot-automated-assighment branch from 93e3458 to ebca98f Compare March 31, 2025 18:49
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the reviews @cjgillot!

r=me tomorrow

@cjgillot
Copy link
Contributor

cjgillot commented Apr 2, 2025

Thanks for doing this, and sorry I never got to do it myself.
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2025

📌 Commit ebca98f has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#139178 (Remove cjgillot from automated review assignment)
 - rust-lang#139184 (Add unstable `--print=crate-root-lint-levels`)
 - rust-lang#139215 (Add `opt-level = "s"` for more std symbolication crates)
 - rust-lang#139232 (Move methods from `Map` to `TyCtxt`, part 5.)
 - rust-lang#139239 (Remove `aux_build` run-make rustc helpers)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 13c2d5e into rust-lang:master Apr 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2025
Rollup merge of rust-lang#139178 - apiraino:remove-cjgillot-automated-assighment, r=cjgillot

Remove cjgillot from automated review assignment

As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Review.20for.20.23137465/with/508540539).

To be clear, this is not a value judgement, it's just a way to improve our fairness when assigning reviews, trying to find a balance between leaving time to Rust contributors review on their terms and availability and avoid having PRs waiting for too long.

> [!IMPORTANT]
> This is not a final decision! Rust contributors are free to re-add themselves back to the active review rotation (if they feel like it) once they have more availability.

cc: `@cjgillot`
@apiraino apiraino deleted the remove-cjgillot-automated-assighment branch April 3, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants