Skip to content

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 20, 2025

This PR fixes the color of inactive entry in rustc pagetoc, particularly with the "Rust" theme.

Before After
image image

Live preview at: http://urgau.rf.gd/book

Related to #140113 (comment)
r? @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2025
@ehuss
Copy link
Contributor

ehuss commented May 20, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 20, 2025

📌 Commit b8732aa has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#140972 (Add TRACING_ENABLED to Machine and add enter_trace_span!())
 - rust-lang#141282 (`core_float_math`: Move functions to `math` module)
 - rust-lang#141288 (Get rid of unnecessary `BufDisplay` abstraction)
 - rust-lang#141289 (use `Self` alias in self types rather than manually substituting it)
 - rust-lang#141291 (link tracking issue in explicit-extern-abis.md)
 - rust-lang#141294 (triagebot: ping me if rustdoc js is modified)
 - rust-lang#141303 (Fix pagetoc inactive color in rustc book)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 13f3f31 into rust-lang:master May 21, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
Rollup merge of rust-lang#141303 - Urgau:pagetoc-fix-color, r=ehuss

Fix pagetoc inactive color in rustc book

This PR fixes the color of inactive entry in rustc pagetoc, particularly with the "Rust" theme.

| Before | After |
|--------|-------|
| ![image](https://github.com/user-attachments/assets/c6c8fe9a-0016-46cb-a638-71a62787b629) | ![image](https://github.com/user-attachments/assets/7146be5b-6ac3-4c9b-8e5a-eedd6ce61314) |

Live preview at: http://urgau.rf.gd/book

Related to rust-lang#140113 (comment)
r? `@ehuss`
@rustbot rustbot added this to the 1.89.0 milestone May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants