Deconstruct values in the HIR visitor #141931
Merged
+147
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
ArtemIsmagilov
changed the title
compiler/rustc_hir/src/intravisit.rs
nnethercote
changed the title
compiler/rustc_hir/src/intravisit.rs
nnethercote
reviewed
Jun 3, 2025
| @@ -1018,8 +1040,9 @@ pub fn walk_const_arg<'v, V: Visitor<'v>>( | |||
| match const_arg.try_as_ambig_ct() { | |||
| Some(ambig_ct) => visitor.visit_const_arg(ambig_ct), | |||
| None => { | |||
| try_visit!(visitor.visit_id(const_arg.hir_id)); | |||
| visitor.visit_infer(const_arg.hir_id, const_arg.span(), InferKind::Const(const_arg)) | |||
| let ConstArg { hir_id, kind: _ } = const_arg; | |||
There was a problem hiding this comment.
kind being skipped here might be a bug. No need to do anything about it in this PR, we can fix it elsewhere, but great that this PR has identified this!
There was a problem hiding this comment.
need reverse?
There was a problem hiding this comment.
Leave it unchanged. If it needs fixing we can do in a follow-up.
nnethercote
reviewed
Jun 3, 2025
| @@ -1288,16 +1332,20 @@ pub fn walk_precise_capturing_arg<'v, V: Visitor<'v>>( | |||
| ) -> V::Result { | |||
| match *arg { | |||
| PreciseCapturingArg::Lifetime(lt) => visitor.visit_lifetime(lt), | |||
| PreciseCapturingArg::Param(param) => visitor.visit_id(param.hir_id), | |||
| PreciseCapturingArg::Param(param) => { | |||
| let PreciseCapturingNonLifetimeArg { hir_id, ident: _, res: _ } = param; | |||
There was a problem hiding this comment.
Skipping the ident here is also suspicious.
There was a problem hiding this comment.
need reverse?
There was a problem hiding this comment.
I filed #141999 to fix this.
|
Can you change the commit message to say "Deconstruct values in the THIR visitor"? Then this will be ready to merge. Thanks. |
|
Thanks for the review! Tell me, taking into account your comments, should I still remove the destructor in match expressions? |
ArtemIsmagilov
force-pushed
the
issue-141849_2
branch
from
0027cf6 to
624e1cd
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 3, 2025
Rollup of 8 pull requests Successful merges: - #141724 (fix(#141141): When expanding `PartialEq`, check equality of scalar types first.) - #141833 (`tests/ui`: A New Order [2/N]) - #141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - #141914 (redesign stage 0 std follow-ups) - #141918 (Deconstruct values in the THIR visitor) - #141923 (Update books) - #141931 (Deconstruct values in the THIR visitor) - #141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
nnethercote
changed the title
|
Whoops, the commit message should have said "HIR visitor" instead of "THIR visitor". Oh well, too late now :) |
|
Thanks again for your help with the first rust commit! |
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jun 9, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#141724 (fix(rust-lang/rust#141141): When expanding `PartialEq`, check equality of scalar types first.) - rust-lang/rust#141833 (`tests/ui`: A New Order [2/N]) - rust-lang/rust#141861 (Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images) - rust-lang/rust#141914 (redesign stage 0 std follow-ups) - rust-lang/rust#141918 (Deconstruct values in the THIR visitor) - rust-lang/rust#141923 (Update books) - rust-lang/rust#141931 (Deconstruct values in the THIR visitor) - rust-lang/rust#141956 (Remove two trait methods from cg_ssa) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I continue to add deconstruction for task #141849
The changes concern a more complex part of the task
compiler/rustc_hir/src/intravisit.rsr? @nnethercote