Skip to content

Conversation

cjgillot
Copy link
Contributor

Tiny improvement I was when trying to profile span hashing.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2025
@Kobzol
Copy link
Member

Kobzol commented Jun 12, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Jun 12, 2025
Do not clone Arc when hashing span.

Tiny improvement I was when trying to profile span hashing.

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->
@rust-bors
Copy link

rust-bors bot commented Jun 12, 2025

⌛ Trying commit a5ff3cc with merge fb07b82

To cancel the try build, run the command @bors2 try cancel.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 12, 2025

☀️ Try build successful (CI)
Build commit: fb07b82 (fb07b82e64a18c5e2764c980d1be979980d9df1a, parent: 14346303d760027e53214e705109a62c0f00b214)

@rust-timer

This comment has been minimized.

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf turns out 🤞

@davidtwco davidtwco removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fb07b82): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.3%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.0%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
-2.1% [-2.4%, -1.8%] 2
All ❌✅ (primary) 0.0% [-1.3%, 1.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.927s -> 756.111s (0.02%)
Artifact size: 372.13 MiB -> 372.13 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2025
@cjgillot
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Jun 13, 2025

📌 Commit a5ff3cc has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 13, 2025
@fmease
Copy link
Member

fmease commented Jun 14, 2025

precedence over next rollup @bors p=5

@bors
Copy link
Collaborator

bors commented Jun 15, 2025

⌛ Testing commit a5ff3cc with merge 0cbc076...

@bors
Copy link
Collaborator

bors commented Jun 15, 2025

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 0cbc076 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2025
@bors bors merged commit 0cbc076 into rust-lang:master Jun 15, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 15, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 32b5152 (parent) -> 0cbc076 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0cbc0764380630780a275c437260e4d4d5f28c92 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. mingw-check-tidy: 70.2s -> 93.3s (32.8%)
  2. x86_64-apple-2: 6721.6s -> 4541.6s (-32.4%)
  3. dist-apple-various: 7657.7s -> 5925.9s (-22.6%)
  4. dist-x86_64-apple: 8891.0s -> 10591.1s (19.1%)
  5. dist-aarch64-msvc: 9489.3s -> 8302.9s (-12.5%)
  6. aarch64-apple: 5325.5s -> 4739.7s (-11.0%)
  7. x86_64-gnu-stable: 8299.9s -> 7537.0s (-9.2%)
  8. dist-ohos-x86_64: 4258.5s -> 3986.2s (-6.4%)
  9. dist-armhf-linux: 4372.9s -> 4651.8s (6.4%)
  10. x86_64-rust-for-linux: 3055.3s -> 2860.9s (-6.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0cbc076): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.9% [3.9%, 3.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.461s -> 757.399s (0.26%)
Artifact size: 372.12 MiB -> 372.20 MiB (0.02%)

@cjgillot cjgillot deleted the span-hash branch June 15, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants