Skip to content

Conversation

compiler-errors
Copy link
Member

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 20, 2025
@compiler-errors
Copy link
Member Author

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jun 20, 2025

⌛ Trying commit 582c2df with merge 39fdb4c

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 20, 2025
Collapse Analysis|Borrowck|PostBorrowckAnalysis when there are no opaques

r? lcnr
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 20, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 20, 2025

☀️ Try build successful (CI)
Build commit: 39fdb4c (39fdb4c569c50e081bd1bc150f9fb2eb6b4326de, parent: 9c4ff566babe632af5e30281a822d1ae9972873b)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (39fdb4c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-7.6%, -0.2%] 16
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -6.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.1% [-13.1%, -1.9%] 5
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.4%, secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-7.6%, -1.3%] 10
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 692.606s -> 694.227s (0.23%)
Artifact size: 372.01 MiB -> 371.94 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 21, 2025
@lcnr
Copy link
Contributor

lcnr commented Jun 22, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 582c2df has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@bors
Copy link
Collaborator

bors commented Jun 29, 2025

⌛ Testing commit 582c2df with merge 35f6036...

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 35f6036 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025
@bors bors merged commit 35f6036 into rust-lang:master Jun 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ed2d759 (parent) -> 35f6036 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 35f6036521777bdc0dcea1f980be4c192962a168 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 5673.5s -> 7897.9s (39.2%)
  2. dist-x86_64-apple: 9853.2s -> 7744.9s (-21.4%)
  3. x86_64-apple-1: 6121.6s -> 7425.1s (21.3%)
  4. aarch64-apple: 4178.0s -> 5031.9s (20.4%)
  5. i686-gnu-2: 5448.9s -> 6210.2s (14.0%)
  6. x86_64-gnu-llvm-19-1: 3277.7s -> 3722.1s (13.6%)
  7. i686-gnu-nopt-1: 7188.1s -> 7973.8s (10.9%)
  8. x86_64-rust-for-linux: 2640.3s -> 2917.2s (10.5%)
  9. x86_64-gnu-debug: 5375.2s -> 5938.4s (10.5%)
  10. dist-ohos-aarch64: 4594.3s -> 4132.1s (-10.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (35f6036): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.1%, 0.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-7.5%, -0.5%] 14
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -6.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.0% [-10.2%, -2.0%] 9
All ❌✅ (primary) - - 0

Cycles

Results (primary 0.4%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
-3.5% [-7.4%, -1.3%] 10
All ❌✅ (primary) 0.4% [-1.1%, 1.8%] 2

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 694.715s -> 695.714s (0.14%)
Artifact size: 371.77 MiB -> 371.68 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants