Enable short-ice for Windows #142844

dpaoliello · 2025-06-21T20:07:04Z

Works fine for x64 without modifications.

x86 MSVC is still failing.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

rustbot · 2025-06-21T20:07:08Z

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-06-21T20:07:09Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-21T20:07:11Z

This PR modifies run-make tests.

cc @jieyouxu

Noratrieb · 2025-06-21T21:50:16Z

(does bors2 support try-jobs in the description or only in the command? let's see. looks like it does!)
@bors2 try

rust-bors · 2025-06-21T21:50:19Z

⌛ Trying commit ac55186 with merge b3a3974…

To cancel the try build, run the command @bors2 try cancel.

Enable short-ice for Windows Works fine with MSVC without modifications. Addresses item in #128602 --- try-job: x86_64-mingw-* try-job: x86_64-msvc-* try-job: i686-msvc-*

rust-bors · 2025-06-22T00:33:53Z

💔 Test failed

CI ❌

jieyouxu · 2025-06-22T00:58:24Z

@bors2 delegate=try

rust-bors · 2025-06-22T00:58:26Z

@dpaoliello can now perform try builds on this pull request

jieyouxu · 2025-06-23T08:34:59Z

I vaguely remember this, maybe the backtrace is somehow different in i686 msvc?
@rustbot author

rustbot · 2025-06-23T08:35:04Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

dpaoliello · 2025-06-23T19:37:02Z

@bors2 try

rust-bors · 2025-06-23T19:37:05Z

⌛ Trying commit a303bed with merge 86d5cbc…

To cancel the try build, run the command @bors2 try cancel.

Enable short-ice for Windows Works fine with MSVC without modifications. Addresses item in #128602 --- x86_64-mingw-* x86_64-msvc-* try-job: i686-msvc-*

rust-bors · 2025-06-23T19:49:04Z

💔 Test failed

CI ❌

dpaoliello · 2025-06-23T19:54:13Z

@bors2 try

rust-bors · 2025-06-23T19:54:17Z

⌛ Trying commit 9e45323 with merge b01f6f1…

To cancel the try build, run the command @bors2 try cancel.

Enable short-ice for Windows Works fine with MSVC without modifications. Addresses item in #128602 --- x86_64-mingw-* x86_64-msvc-* try-job: i686-msvc-*

rust-bors · 2025-06-23T22:33:29Z

💔 Test failed

CI ❌

jieyouxu · 2025-06-25T00:04:46Z

Yeah, that's fine with me.

jieyouxu · 2025-06-25T00:05:18Z

@dpaoliello can u take this PR out of draft so bors will let this go through? r=me

@bors delegate+

bors · 2025-06-25T00:05:22Z

✌️ @dpaoliello, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

dpaoliello · 2025-06-25T00:16:06Z

@bors r=@jieyouxu

bors · 2025-06-25T00:16:09Z

📌 Commit 4c7f054 has been approved by jieyouxu

It is now in the queue for this repository.

Enable short-ice for Windows Works fine for x64 without modifications. x86 MSVC is still failing. Addresses item in rust-lang#128602 --- try-job: x86_64-mingw-* try-job: x86_64-msvc-* try-job: i686-msvc-*

Rollup of 15 pull requests Successful merges: - #135731 (Implement parsing of pinned borrows) - #138780 (Add `#[loop_match]` for improved DFA codegen) - #142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - #142633 (Error on invalid signatures for interrupt ABIs) - #142768 (Avoid a bitcast FFI call in transmuting) - #142825 (Port `#[track_caller]` to the new attribute system) - #142844 (Enable short-ice for Windows) - #142934 (Tweak `-Zmacro-stats` measurement.) - #142955 (Couple of test suite fixes for cg_clif) - #142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - #142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - #142982 (Corrected spelling mistake in c_str.rs) - #142983 (Taint body on invalid call ABI) - #142988 (Update wasm-component-ld to 0.5.14) - #142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142844 - dpaoliello:short-ice, r=jieyouxu Enable short-ice for Windows Works fine for x64 without modifications. x86 MSVC is still failing. Addresses item in #128602 --- try-job: x86_64-mingw-* try-job: x86_64-msvc-* try-job: i686-msvc-*

Rollup of 15 pull requests Successful merges: - rust-lang/rust#135731 (Implement parsing of pinned borrows) - rust-lang/rust#138780 (Add `#[loop_match]` for improved DFA codegen) - rust-lang/rust#142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - rust-lang/rust#142633 (Error on invalid signatures for interrupt ABIs) - rust-lang/rust#142768 (Avoid a bitcast FFI call in transmuting) - rust-lang/rust#142825 (Port `#[track_caller]` to the new attribute system) - rust-lang/rust#142844 (Enable short-ice for Windows) - rust-lang/rust#142934 (Tweak `-Zmacro-stats` measurement.) - rust-lang/rust#142955 (Couple of test suite fixes for cg_clif) - rust-lang/rust#142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - rust-lang/rust#142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - rust-lang/rust#142982 (Corrected spelling mistake in c_str.rs) - rust-lang/rust#142983 (Taint body on invalid call ABI) - rust-lang/rust#142988 (Update wasm-component-ld to 0.5.14) - rust-lang/rust#142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2025-06-29T14:15:24Z

This is causing spurious test failures, apparently on multiple occasions. We should probably revert this PR.
Also see Zulip

Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang#143198. FYI `@dpaoliello` (I couldn't reproduce this easily locally either)

Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang#143198. FYI ``@dpaoliello`` (I couldn't reproduce this easily locally either)

Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang#143198. FYI ```@dpaoliello``` (I couldn't reproduce this easily locally either)

Rollup merge of #143199 - jieyouxu:short-ice, r=RalfJung Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in #142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in #143198. FYI ```@dpaoliello``` (I couldn't reproduce this easily locally either)

Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in rust-lang/rust#142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in rust-lang/rust#143198. FYI ```@dpaoliello``` (I couldn't reproduce this easily locally either)

…kingjubilee Rollup of 15 pull requests Successful merges: - rust-lang#135731 (Implement parsing of pinned borrows) - rust-lang#138780 (Add `#[loop_match]` for improved DFA codegen) - rust-lang#142453 (Windows: make `read_dir` stop iterating after the first error is encountered) - rust-lang#142633 (Error on invalid signatures for interrupt ABIs) - rust-lang#142768 (Avoid a bitcast FFI call in transmuting) - rust-lang#142825 (Port `#[track_caller]` to the new attribute system) - rust-lang#142844 (Enable short-ice for Windows) - rust-lang#142934 (Tweak `-Zmacro-stats` measurement.) - rust-lang#142955 (Couple of test suite fixes for cg_clif) - rust-lang#142977 (rustdoc: Don't mark `#[target_feature]` functions as ⚠) - rust-lang#142980 (Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect) - rust-lang#142982 (Corrected spelling mistake in c_str.rs) - rust-lang#142983 (Taint body on invalid call ABI) - rust-lang#142988 (Update wasm-component-ld to 0.5.14) - rust-lang#142993 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jun 21, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025

dpaoliello force-pushed the short-ice branch from ac55186 to a303bed Compare June 23, 2025 19:36

dpaoliello marked this pull request as draft June 23, 2025 19:36

rust-bors bot added a commit that referenced this pull request Jun 23, 2025

Auto merge of #142844 - dpaoliello:short-ice, r=<try>

86d5cbc

Enable short-ice for Windows Works fine with MSVC without modifications. Addresses item in #128602 --- x86_64-mingw-* x86_64-msvc-* try-job: i686-msvc-*

This comment has been minimized.

Sign in to view

dpaoliello force-pushed the short-ice branch from a303bed to 9e45323 Compare June 23, 2025 19:53

rust-bors bot added a commit that referenced this pull request Jun 23, 2025

Auto merge of #142844 - dpaoliello:short-ice, r=<try>

b01f6f1

Enable short-ice for Windows Works fine with MSVC without modifications. Addresses item in #128602 --- x86_64-mingw-* x86_64-msvc-* try-job: i686-msvc-*

Enable short-ice for Windows

4c7f054

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2025

jieyouxu approved these changes Jun 25, 2025

View reviewed changes

dpaoliello marked this pull request as ready for review June 25, 2025 00:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025

This was referenced Jun 25, 2025

Rollup of 15 pull requests #142995

Closed

Rollup of 15 pull requests #142997

Merged

bors merged commit 4af75b2 into rust-lang:master Jun 25, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 25, 2025

dpaoliello deleted the short-ice branch June 25, 2025 22:28

jieyouxu mentioned this pull request Jun 29, 2025

Re-disable tests/run-make/short-ice on Windows MSVC again #143199

Merged

Enable short-ice for Windows #142844

Enable short-ice for Windows #142844

Uh oh!

Conversation

dpaoliello commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

Noratrieb commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Jun 21, 2025

Uh oh!

rust-bors bot commented Jun 22, 2025

Uh oh!

jieyouxu commented Jun 22, 2025

Uh oh!

rust-bors bot commented Jun 22, 2025

Uh oh!

jieyouxu commented Jun 23, 2025

Uh oh!

rustbot commented Jun 23, 2025

Uh oh!

dpaoliello commented Jun 23, 2025

Uh oh!

rust-bors bot commented Jun 23, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 23, 2025

Uh oh!

dpaoliello commented Jun 23, 2025

Uh oh!

rust-bors bot commented Jun 23, 2025

Uh oh!

rust-bors bot commented Jun 23, 2025

Uh oh!

jieyouxu commented Jun 25, 2025

Uh oh!

jieyouxu commented Jun 25, 2025

Uh oh!

bors commented Jun 25, 2025

Uh oh!

dpaoliello commented Jun 25, 2025

Uh oh!

bors commented Jun 25, 2025

Uh oh!

Uh oh!

RalfJung commented Jun 29, 2025

Uh oh!

Uh oh!

dpaoliello commented Jun 21, 2025 •

edited

Loading

Noratrieb commented Jun 21, 2025 •

edited

Loading