Skip to content

add multi-arch asm! label operand test #143227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add multi-arch asm! label operand test #143227

wants to merge 1 commit into from

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jun 30, 2025 •
edited
Loading

Added this since the other label operand tests are only for x86

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025
@lcnr
Copy link
Contributor

lcnr commented Jun 30, 2025

don't know how label works

r? @Amanieu maybe

@rustbot rustbot assigned Amanieu and unassigned lcnr Jun 30, 2025
Amanieu
Amanieu reviewed Jun 30, 2025
View reviewed changes
tests/ui/asm/label-operand.rs
@@ -0,0 +1,47 @@
//@ run-pass
//@ needs-asm-support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to fail on targets that aren't x86, arm or risc-v. Either add a fallback or split this into separate tests that are only enabled for that particular architecture.

@tshepang tshepang mentioned this pull request Jul 1, 2025
Merged
@Hoverbear Hoverbear mentioned this pull request Aug 6, 2025
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Aug 7, 2025
@bors-ferrocene @tshepang
Merge #1633
bdbfe16 
1633: [1.88] add test: inline assembly label operand r=Hoverbear a=tshepang

Backports rust-lang/rust#143227 as we need it for satisfying traceability matrix.

Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
@apiraino
Copy link
Contributor

Switching to waiting on author due to this comment. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @lcnr @apiraino @Amanieu