Skip to content

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jul 2, 2025

Noticed the filename is wrong, then took advantage of being there by adding Reference id

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2025
@compiler-errors
Copy link
Member

please squash this into one commit; there's no need to make this two commits if they're both just tiny tweaks.

@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Jul 2, 2025

Also please adjust the description and PR title to actually reflect what this PR does. I think out of the rename and adding a reference ID, the latter is actually the more important part of this PR, so it would be nice if that had been mentioned.

Because right now the title is very vague.

@tshepang tshepang changed the title fix filename for test add reference id to test, and fix filename Jul 3, 2025
@tshepang
Copy link
Member Author

tshepang commented Jul 3, 2025

squashed, though I thought the changes were distinct enough to deserve separate commits

@karolzwolak karolzwolak added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants