[TOY] Extend GVN to perform local value numbering. #143333
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
local-value-numbering
branch
from
c7dac45 to
62766e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
that referenced
this pull request
Jul 5, 2025
[TOY] Extend GVN to perform local value numbering. This PR is more a toy than anything else, but I still think the implementation is sound. Current GVN MIR opt can be easily extended to track values that change inside a basic block. This PR attempts that. r? `@ghost` for perf
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (faceb52): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 9.1%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 44.8%, secondary 29.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 458.797s -> 582.037s (26.86%) |
rustbot
added
perf-regression
cjgillot
force-pushed
the
local-value-numbering
branch
from
c3be10b to
e521268
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
bors
added a commit
that referenced
this pull request
Jul 6, 2025
[TOY] Extend GVN to perform local value numbering. This PR is more a toy than anything else, but I still think the implementation is sound. Current GVN MIR opt can be easily extended to track values that change inside a basic block. This PR attempts that. r? `@ghost` for perf
cjgillot
force-pushed
the
local-value-numbering
branch
from
e521268 to
0293254
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 6, 2025
[TOY] Extend GVN to perform local value numbering. This PR is more a toy than anything else, but I still think the implementation is sound. Current GVN MIR opt can be easily extended to track values that change inside a basic block. This PR attempts that. r? `@ghost` for perf
This comment has been minimized.
This comment has been minimized.
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Note: we had some network issues on the collector and this benchmark was restarted multiple times. I hope that it didn't affect the results, but in case it comes out weirdly, I'd rerun it (this PR would probably have "weird" results anyway though 😆). |
|
Finished benchmarking commit (4d16c54): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 48.7%, secondary 33.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 8.6%, secondary 14.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 460.756s -> 480.789s (4.35%) |
rustbot
removed
the
S-waiting-on-perf
cjgillot
force-pushed
the
local-value-numbering
branch
from
0293254 to
290a3bc
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Aug 23, 2025
[TOY] Extend GVN to perform local value numbering.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (1e45fee): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 58.2%, secondary 55.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 5.4%, secondary 11.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 467.196s -> 479.382s (2.61%) |
rustbot
removed
the
S-waiting-on-perf
|
☔ The latest upstream changes (presumably #145923) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more a toy than anything else, but I still think the implementation is sound.
Current GVN MIR opt can be easily extended to track values that change inside a basic block. This PR attempts that.
r? @ghost for perf