Make IoSlice and IoSliceMut methods unstably const
#144090
Open
+32
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
rustbot
added
S-waiting-on-review
|
If this looks good, I'll open a tracking issue and link it. |
|
r? libs-api |
rustbot
added
the
T-libs-api
|
@BurntSushi Friendly ping. Would you mind taking a look at this? |
tgross35
added
the
I-libs-api-nominated
|
This seems fine; if we wind up with an obscure platform for which the vector type can't be constructed at comptime for some reason, we would probably use the Nominated. |
tgross35
requested changes
Sep 3, 2025
| @@ -1338,8 +1338,9 @@ impl<'a> IoSliceMut<'a> { | |||
| /// | |||
| /// Panics on Windows if the slice is larger than 4GB. | |||
| #[stable(feature = "iovec", since = "1.36.0")] | |||
| #[rustc_const_unstable(feature = "io_slice_const", issue = "none")] | |||
There was a problem hiding this comment.
Please make a tracking issue for this
tgross35
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables constructing
IoSliceandIoSliceMutin const contexts without users needing to break the platform abstraction by doing the cast themselves. This is useful for statics.Since all current and plausible future platforms use simple slice-like structs, this should not impose a burden when adding a new platform with a different struct.