Remove tidy checks for `tests/ui/issues/` #144173

Kivooeo · 2025-07-19T10:38:09Z

r? @jieyouxu

As it is making cleanup efforts more difficult.

This change was discussed here #t-compiler > Discussion for ui test suite improvements @ 💬

rustbot · 2025-07-19T10:38:13Z

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-07-19T10:38:15Z

There are changes to the tidy tool.

cc @jieyouxu

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

jieyouxu

Don't leave commented out code, just delete it.

triagebot.toml

jieyouxu · 2025-07-19T10:52:00Z

Once work on tests/ui/issues/ is complete, this change will be reverted accordingly.

Once that work is complete, we won't need this check (there were way too many tests under tests/ui/issues/, which is why this check exists in the first place).

src/tools/tidy/src/ui_tests.rs

jieyouxu · 2025-07-19T15:31:05Z

spellcheck is broken for other reasons, u can ignore.

Kivooeo · 2025-07-19T15:46:10Z

Should be fine now, only reason I need tidy to ignore deleted issue-*.rs files from issues/ is to completely remove any interactions with issues.txt file while working on tests

I will remove all moved tests from issues.txt in separate PR after issues/ is clean

bors · 2025-07-20T01:51:52Z

☔ The latest upstream changes (presumably #144181) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-07-21T02:35:04Z

Should be fine now, only reason I need tidy to ignore deleted issue-*.rs files from issues/ is to completely remove any interactions with issues.txt file while working on tests

I will remove all moved tests from issues.txt in separate PR after issues/ is clean

Can you rebless issues.txt (perhaps manually) to remove all ui/issues/** entries? I feel like leaving that in is quite surprising (especially given that said tests might not even exist after getting moved).

@rustbot author

rustbot · 2025-07-21T02:35:09Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Kivooeo · 2025-07-21T07:04:03Z

Can you rebless issues.txt (perhaps manually) to remove all ui/issues/** entries

With keeping removing this checks?

jieyouxu · 2025-07-21T07:23:58Z

My understanding of the intention is that:

We want to skip the issues-* check for tests/ui/issues/, because there are now actually contributors (like you) trying to clean it up, so that gets in the way as issue-* tests get removed from tests/ui/issues/. The issues.txt is a listing of all issues-* tests. We should update this listing to remove ui/issues/ ones, as we are no longer tracking issue-* tests under tests/ui/issues/.

Kivooeo · 2025-07-21T14:10:49Z

@rustbot ready

deleted all lines that starts with ui/issues/

reverted this filter on issues/ tests from here

rust/src/tools/tidy/src/ui_tests.rs

Line 78 in bcaa795

let mut remaining_issue_names: BTreeSet<&str> = allowed_issue_names.clone();

but kept this, because otherwise it's threw errors about existed tests

rust/src/tools/tidy/src/ui_tests.rs

Lines 133 to 134 in bcaa795

    
           if !remaining_issue_names.remove(stripped_path.as_str()) 
        
               && !stripped_path.starts_with("ui/issues/")

Remove tidy checks for `tests/ui/issues/` r? `@jieyouxu` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? ``@jieyouxu`` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? ```@jieyouxu``` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Rollup of 8 pull requests Successful merges: - #144094 (Ensure we codegen the main fn) - #144173 (Remove tidy checks for `tests/ui/issues/`) - #144218 (Use serde for target spec json deserialize) - #144221 (generate elf symbol version in raw-dylib) - #144234 (Fix broken TLS destructors on 32-bit win7) - #144256 (Don't ICE on non-TypeId metadata within TypeId) - #144272 (resolve: Make disambiguators for underscore bindings module-local (take 2)) - #144276 (Use less HIR in check_private_in_public.) r? `@ghost` `@rustbot` modify labels: rollup

Remove tidy checks for `tests/ui/issues/` r? ````@jieyouxu```` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? `````@jieyouxu````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? ``````@jieyouxu`````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? ```````@jieyouxu``````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Remove tidy checks for `tests/ui/issues/` r? ````````@jieyouxu```````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Rollup of 10 pull requests Successful merges: - #144173 (Remove tidy checks for `tests/ui/issues/`) - #144234 (Fix broken TLS destructors on 32-bit win7) - #144239 (Clean `rustc/parse/src/lexer` to improve maintainability) - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - #144256 (Don't ICE on non-TypeId metadata within TypeId) - #144290 (update tests/ui/SUMMARY.md) - #144292 (mbe: Use concrete type for `get_unused_rule`) - #144298 (coverage: Enlarge empty spans during MIR instrumentation, not codegen) - #144311 (Add powerpc64le-unknown-linux-musl to CI rustc targets) - #144315 (bootstrap: add package.json and package-lock.json to dist tarball) r? `@ghost` `@rustbot` modify labels: rollup

Remove tidy checks for `tests/ui/issues/` r? `````````@jieyouxu````````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

Rollup of 10 pull requests Successful merges: - #144173 (Remove tidy checks for `tests/ui/issues/`) - #144234 (Fix broken TLS destructors on 32-bit win7) - #144239 (Clean `rustc/parse/src/lexer` to improve maintainability) - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - #144256 (Don't ICE on non-TypeId metadata within TypeId) - #144290 (update tests/ui/SUMMARY.md) - #144292 (mbe: Use concrete type for `get_unused_rule`) - #144298 (coverage: Enlarge empty spans during MIR instrumentation, not codegen) - #144311 (Add powerpc64le-unknown-linux-musl to CI rustc targets) - #144315 (bootstrap: add package.json and package-lock.json to dist tarball) r? `@ghost` `@rustbot` modify labels: rollup try-job: x86_64-gnu-aux

Rollup of 9 pull requests Successful merges: - #144173 (Remove tidy checks for `tests/ui/issues/`) - #144234 (Fix broken TLS destructors on 32-bit win7) - #144239 (Clean `rustc/parse/src/lexer` to improve maintainability) - #144256 (Don't ICE on non-TypeId metadata within TypeId) - #144290 (update tests/ui/SUMMARY.md) - #144292 (mbe: Use concrete type for `get_unused_rule`) - #144298 (coverage: Enlarge empty spans during MIR instrumentation, not codegen) - #144311 (Add powerpc64le-unknown-linux-musl to CI rustc targets) - #144315 (bootstrap: add package.json and package-lock.json to dist tarball) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144173 - Kivooeo:tidy_checks, r=jieyouxu Remove tidy checks for `tests/ui/issues/` r? ``````````@jieyouxu`````````` As it is making cleanup efforts more difficult. This change was discussed here [#t-compiler > Discussion for ui test suite improvements @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Discussion.20for.20ui.20test.20suite.20improvements/near/529566433)

rustbot assigned jieyouxu Jul 19, 2025

Kivooeo changed the title ~~removed tidy check on issues files~~ Removed tidy checks on issues.txt Jul 19, 2025

Kivooeo force-pushed the tidy_checks branch from 76c7fc9 to ea59000 Compare July 19, 2025 10:47

jieyouxu reviewed Jul 19, 2025

View reviewed changes

triagebot.toml Outdated Show resolved Hide resolved

Kivooeo force-pushed the tidy_checks branch 2 times, most recently from da05401 to 3720916 Compare July 19, 2025 10:56

jieyouxu reviewed Jul 19, 2025

View reviewed changes

src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved

src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved

src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved

src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved

Kivooeo force-pushed the tidy_checks branch from 3720916 to d2cf0c6 Compare July 19, 2025 11:18

Kivooeo commented Jul 19, 2025

View reviewed changes

src/tools/tidy/src/ui_tests.rs Outdated Show resolved Hide resolved

Kivooeo force-pushed the tidy_checks branch from d2cf0c6 to e30631c Compare July 19, 2025 15:29

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025

removed tidy check on issues files

bcaa795

Kivooeo force-pushed the tidy_checks branch from e30631c to bcaa795 Compare July 21, 2025 09:52

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 21, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 22, 2025

jieyouxu changed the title ~~Removed tidy checks on issues.txt~~ Removed tidy checks for tests/ui/issues/ Jul 22, 2025

jieyouxu mentioned this pull request Jul 22, 2025

Rehome 35 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144089

Merged

Kivooeo changed the title ~~Removed tidy checks for tests/ui/issues/~~ Remove tidy checks for tests/ui/issues/ Jul 22, 2025

matthiaskrgr mentioned this pull request Jul 22, 2025

Rollup of 9 pull requests #144309

Closed

matthiaskrgr mentioned this pull request Jul 22, 2025

Rollup of 8 pull requests #144313

Closed

matthiaskrgr mentioned this pull request Jul 22, 2025

Rollup of 8 pull requests #144325

Closed

jhpratt mentioned this pull request Jul 23, 2025

Rollup of 12 pull requests #144343

Closed

jhpratt mentioned this pull request Jul 23, 2025

Rollup of 12 pull requests #144345

Closed

matthiaskrgr mentioned this pull request Jul 23, 2025

Rollup of 11 pull requests #144346

Closed

matthiaskrgr mentioned this pull request Jul 23, 2025

Rollup of 10 pull requests #144348

Closed

matthiaskrgr mentioned this pull request Jul 23, 2025

Rollup of 10 pull requests #144349

Closed

GuillaumeGomez mentioned this pull request Jul 23, 2025

Rollup of 12 pull requests #144355

Closed

matthiaskrgr mentioned this pull request Jul 23, 2025

Rollup of 9 pull requests #144360

Merged

bors merged commit 4177f19 into rust-lang:master Jul 23, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 23, 2025

Remove tidy checks for tests/ui/issues/ #144173

Remove tidy checks for tests/ui/issues/ #144173

Uh oh!

Conversation

Kivooeo commented Jul 19, 2025 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 19, 2025

Uh oh!

rustbot commented Jul 19, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 19, 2025

Uh oh!

Kivooeo commented Jul 19, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

rustbot commented Jul 21, 2025

Uh oh!

Kivooeo commented Jul 21, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

Kivooeo commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

Remove tidy checks for `tests/ui/issues/` #144173

Remove tidy checks for `tests/ui/issues/` #144173

Kivooeo commented Jul 19, 2025 •

edited by jieyouxu

Loading

jieyouxu commented Jul 19, 2025 •

edited

Loading