Change regex! macro to expand to a constexpr, allowing to put it in a static #14423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[doc(hidden)] | ||
| #[allow(visible_private_types)] | ||
| pub fn names_iter<'a>(&'a self) -> NamesIter<'a> { |
There was a problem hiding this comment.
In addition to doc(hidden), can you make this #[experimental]?
|
This looks pretty awesome to me, nice work! Just a minor nit, otherwise r=me |
|
Nit resolved ;) |
bors
added a commit
that referenced
this pull request
May 25, 2014
This patch changes the internals of `Regex` and `regex!()` such that ```rust static RE: Regex = regex!(...); ``` is valid. It doesn't change anything about the actual regex implementation, it just changes the type to something that can be constructed as a const expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the internals of
Regexandregex!()such thatis valid. It doesn't change anything about the actual regex implementation, it just changes the type to something that can be constructed as a const expression.