Skip to content

add Option::reduce #144274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

add Option::reduce #144274

merged 1 commit into from
Aug 27, 2025

Conversation

Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Jul 21, 2025 •
edited by rustbot
Loading

Tracking issue: #144273

@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 21, 2025
@Qelxiros Qelxiros mentioned this pull request Jul 21, 2025
Open
3 tasks
tgross35
tgross35 reviewed Jul 29, 2025
View reviewed changes
tgross35
tgross35 reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit and please squash, then lgtm

@tgross35 tgross35 assigned tgross35 and unassigned thomcc Aug 27, 2025
@tgross35
Copy link
Contributor

Thank you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 27, 2025

📌 Commit 613080b has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 27, 2025
Merged
bors added a commit that referenced this pull request Aug 27, 2025
@bors
Auto merge of #145923 - matthiaskrgr:rollup-rkejtos, r=matthiaskrgr
3c91be7 
Rollup of 6 pull requests

Successful merges:

 - #144274 (add Option::reduce)
 - #145562 (Simplify macro generating ToString implementations for `&…&str`)
 - #145625 (improve float to_degrees/to_radians rounding comments and impl)
 - #145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`)
 - #145885 (Inherit TCC in debuginfo tests on macOS)
 - #145905 (Stop calling unwrap when format foreign has trailing dollar)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1e90922 into rust-lang:master Aug 27, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
rust-timer added a commit that referenced this pull request Aug 27, 2025
@rust-timer
Unrolled build for #144274
12ccfe5 
Rollup merge of #144274 - Qelxiros:option-reduce, r=tgross35

add Option::reduce

Tracking issue: #144273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Qelxiros @rustbot @tgross35 @bors @thomcc