rustdoc: avoid allocating a temp String for aliases in search index #144320
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Looks good to me. Please fix CI then I'll r+ it, thanks! |
lolbinarycat
force-pushed
the
rustdoc-search_index-BTreeMap-str
branch
from
687ba3c to
9e75032
Compare
|
@GuillaumeGomez CI passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the optimization I talked about in #143988 (comment)
I got around the Serialize issue using the newtype pattern. The wrapper type could be factored out into a helper that would work with anything that impls
AsRef<&str>, but I'm not sure if that would be helpful anywhere else.r? @GuillaumeGomez