Rollup of 7 pull requests #144546

jhpratt · 2025-07-27T21:17:32Z

Successful merges:

Remove [T]::array_chunks(_mut) #143289 (Remove [T]::array_chunks(_mut))
Port the proc macro attributes to the new attribute parsing infrastructure #143607 (Port the proc macro attributes to the new attribute parsing infrastructure)
Remove compiler-builtins-{no-asm,mangled-names} #144471 (Remove compiler-builtins-{no-asm,mangled-names})
bump cargo_metadata #144495 (bump cargo_metadata)
rustdoc: save target modifiers #144523 (rustdoc: save target modifiers)
check_static_item: explain should_check_for_sync choices #144534 (check_static_item: explain should_check_for_sync choices)
miri: for ABI mismatch errors, say which argument is the problem #144535 (miri: for ABI mismatch errors, say which argument is the problem)

Failed merges:

miri subtree update #144536 (miri subtree update)

r? @ghost
@rustbot modify labels: rollup

This feature used to be for when Cranelift didn't support inline assembly, but its last uses were removed in 52933e0 ("Don't disable inline asm usage in compiler-builtins when the cranelift backend is enabled"). and cba05a7 ("Support naked functions"). This doesn't remove the feature from the `compiler-builtins` crate, that will be done separately in the subtree repo.

This config was added in 207de01 ("libary: Forward compiler-builtins "asm" and "mangled-names" feature") but it does not appear this has ever been used. The PR adding it (RUST-78472) says that this was exposed to help with configuration and points at the [Hermit Cargo config], but as far as I can tell, this feature name has never been mentioned in that repository's git history. Thus, clean up a seemingly unneeded feature. [Hermit Cargo config]: https://github.com/hermit-os/hermit-rs/blob/ab2b830930e6a9a98c8294997a8183feeabeda4a/.cargo/config

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

`rustdoc` was filling a `target_modifiers` variable, but it was not using the result. In turn, that means that trying to use a dependency that set a target modifier fails. For instance, running: ```sh RUSTC_BOOTSTRAP=1 rustc --edition=2024 --target=aarch64-unknown-none-softfloat --sysroot=/dev/null --emit=metadata -Zfixed-x18 --crate-type rlib --crate-name core $(rustc --print sysroot)/lib/rustlib/src/rust/library/core/src/lib.rs echo '#![allow(internal_features)] ' | RUSTC_BOOTSTRAP=1 rustdoc --edition=2021 --target=aarch64-unknown-none-softfloat --sysroot=/dev/null -Zfixed-x18 --extern core=libcore.rmeta - ``` will fail with: ```text error: mixing `-Zfixed-x18` will cause an ABI mismatch in crate `rust_out` | = help: the `-Zfixed-x18` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely = note: unset `-Zfixed-x18` in this crate is incompatible with `-Zfixed-x18=` in dependency `core` = help: set `-Zfixed-x18=` in this crate or unset `-Zfixed-x18` in `core` = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=fixed-x18` to silence this error ``` Thus save the targets modifiers in `Options` to then pass it to the session options, so that eventually the diff can be performed as expected in `report_incompatible_target_modifiers()`. Fixes: rust-lang#144521 Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

…pratt Remove `[T]::array_chunks(_mut)` Since libs-api is proposing as much in rust-lang#74985 (comment) Closes rust-lang#74985 Closes rust-lang#76354

…r=jdonszelmann,traviscross Port the proc macro attributes to the new attribute parsing infrastructure Ports `#[proc_macro]`, `#[proc_macro_attribute]`, `#[proc_macro_derive]` and `#[rustc_builtin_macro]` to the new attribute parsing infrastructure for rust-lang#131229 (comment) I've split this PR into commits for reviewability, and left some comments to clarify things I did 4 related attributes in one PR because they share a lot of their code and logic, and doing them separately is kind of annoying as I need to leave both the old and new parsing in place then. r? `@oli-obk` cc `@jdonszelmann`

…Amanieu Remove `compiler-builtins-{no-asm,mangled-names}` Remove `compiler-builtins-no-asm` This feature used to be for when Cranelift didn't support inline assembly, but its last uses were removed in 52933e0 ("Don't disable inline asm usage in compiler-builtins when the cranelift backend is enabled"). and cba05a7 ("Support naked functions"). This doesn't remove the feature from the `compiler-builtins` crate, that will be done separately in the subtree repo. --- Remove `compiler-builtins-mangled-names` This config was added in 207de01 ("libary: Forward compiler-builtins "asm" and "mangled-names" feature") but it does not appear this has ever been used. The PR adding it (rust-lang#78472) says that this was exposed to help with configuration and points at the [Hermit Cargo config], but as far as I can tell, this feature name has never been mentioned in that repository's git history. Thus, clean up a seemingly unneeded feature. [Hermit Cargo config]: https://github.com/hermit-os/hermit-rs/blob/ab2b830930e6a9a98c8294997a8183feeabeda4a/.cargo/config

bump cargo_metadata Bumps cargo_metadata. Change that required fixes is: oli-obk/cargo_metadata@e3373d0

…GuillaumeGomez rustdoc: save target modifiers `rustdoc` was filling a `target_modifiers` variable, but it was not using the result. In turn, that means that trying to use a dependency that set a target modifier fails. For instance, running: ```sh RUSTC_BOOTSTRAP=1 rustc --edition=2024 --target=aarch64-unknown-none-softfloat --sysroot=/dev/null --emit=metadata -Zfixed-x18 --crate-type rlib --crate-name core $(rustc --print sysroot)/lib/rustlib/src/rust/library/core/src/lib.rs echo '#![allow(internal_features)] ' | RUSTC_BOOTSTRAP=1 rustdoc --edition=2021 --target=aarch64-unknown-none-softfloat --sysroot=/dev/null -Zfixed-x18 --extern core=libcore.rmeta - ``` will fail with: ```text error: mixing `-Zfixed-x18` will cause an ABI mismatch in crate `rust_out` | = help: the `-Zfixed-x18` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely = note: unset `-Zfixed-x18` in this crate is incompatible with `-Zfixed-x18=` in dependency `core` = help: set `-Zfixed-x18=` in this crate or unset `-Zfixed-x18` in `core` = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=fixed-x18` to silence this error ``` Thus save the targets modifiers in `Options` to then pass it to the session options, so that eventually the diff can be performed as expected in `report_incompatible_target_modifiers()`. Cc: `@azhogin` Fixes: rust-lang#144521

…compiler-errors check_static_item: explain should_check_for_sync choices Follow-up to rust-lang#144226. r? `@oli-obk`

…ler-errors miri: for ABI mismatch errors, say which argument is the problem

jhpratt · 2025-07-27T21:17:43Z

@bors r+ rollup=never p=5

bors · 2025-07-27T21:17:45Z

📌 Commit e172e1e has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-07-27T22:04:39Z

⌛ Testing commit e172e1e with merge d794fe4...

Rollup of 7 pull requests Successful merges: - #143289 (Remove `[T]::array_chunks(_mut)`) - #143607 (Port the proc macro attributes to the new attribute parsing infrastructure) - #144471 (Remove `compiler-builtins-{no-asm,mangled-names}`) - #144495 (bump cargo_metadata) - #144523 (rustdoc: save target modifiers) - #144534 (check_static_item: explain should_check_for_sync choices) - #144535 (miri: for ABI mismatch errors, say which argument is the problem) Failed merges: - #144536 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-07-27T23:03:56Z

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

     |
help: there is a method `rchunks_mut` with a similar name, but with different arguments
    --> /rustc/d794fe492ac7d98795c009680acc3c572fc5656c/library/core/src/slice/mod.rs:1724:5
     |
1724 |     pub const fn rchunks_mut(&mut self, chunk_size: usize) -> RChunksMut<'_, T> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0599`.
[RUSTC-TIMING] std test:false 2.811
warning: `std` (lib) generated 1 warning

bors · 2025-07-27T23:04:40Z

💔 Test failed - checks-actions

scottmcm and others added 21 commits July 1, 2025 20:25

Remove [T]::array_chunks(_mut)

bc6d1c2

Add attributes to AttributeKind

39235be

Implement check_attr

c4e7cb8

Parsers for the attributes

2f50c78

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Use the new attributes throughout the codebase

ec63700

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Update test results

fea7809

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Remove now un-used code

e64f75b

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Fix tooling

97b6521

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

bump cargo_metadata

ad4b869

check_static_item: explain should_check_for_sync choices

da1991d

miri: for ABI mismatch errors, say which argument is the problem

296586f

Rollup merge of rust-lang#143289 - scottmcm:remove-array-chunks, r=jh…

5eb49b3

…pratt Remove `[T]::array_chunks(_mut)` Since libs-api is proposing as much in rust-lang#74985 (comment) Closes rust-lang#74985 Closes rust-lang#76354

Rollup merge of rust-lang#144495 - klensy:cargo_metadata, r=lqd

770c3a6

bump cargo_metadata Bumps cargo_metadata. Change that required fixes is: oli-obk/cargo_metadata@e3373d0

Rollup merge of rust-lang#144534 - RalfJung:should_check_for_sync, r=…

45c1788

…compiler-errors check_static_item: explain should_check_for_sync choices Follow-up to rust-lang#144226. r? `@oli-obk`

Rollup merge of rust-lang#144535 - RalfJung:abi-mismatch-err, r=compi…

e172e1e

…ler-errors miri: for ABI mismatch errors, say which argument is the problem

rustbot added the rollup A PR which is a rollup label Jul 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2025

matthiaskrgr mentioned this pull request Jul 27, 2025

Remove [T]::array_chunks(_mut) #143289

Merged

matthiaskrgr closed this Jul 27, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2025

jhpratt deleted the rollup-o8vt8ft branch July 27, 2025 23:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #144546

Rollup of 7 pull requests #144546

Uh oh!

jhpratt commented Jul 27, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

rust-log-analyzer commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #144546

Rollup of 7 pull requests #144546

Uh oh!

Conversation

jhpratt commented Jul 27, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

rust-log-analyzer commented Jul 27, 2025

Uh oh!

bors commented Jul 27, 2025

Uh oh!

Uh oh!

jhpratt commented Jul 27, 2025 •

edited by rustbot

Loading