fix #[loop_match] on diverging loop
#144783
Open
+50
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
added
the
F-loop_match
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Aug 1, 2025
this generated invalid MIR before
folkertdev
force-pushed
the
loop-match-diverging-loop
branch
from
13d09ba to
36bf31d
Compare
|
r? compiler given that this was debugged by the both of us. |
|
I guess but also we have all the context here, it's a one-liner, and has no consequences outside of loop-match code. |
|
Some changes occurred in match lowering cc @Nadrieril |
folkertdev
commented
Aug 1, 2025
Comment on lines
-298
to
+302
| let scrutinee_place_builder = | ||
| unpack!(body_block = this.as_place_builder(body_block, scrutinee)); | ||
| let scrutinee_span = this.thir.exprs[scrutinee].span; | ||
| let scrutinee_place_builder = unpack!( | ||
| body_block = this.lower_scrutinee(body_block, scrutinee, scrutinee_span) | ||
| ); | ||
|
|
There was a problem hiding this comment.
this change adds a place mention of the scrutinee that was missing before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #132306
fixes #144492
fixes #143806
fixes #144493
fixes #144781
this generated invalid MIR before
r? @bjorn3